From: Jonathan Cameron <jic23@kernel.org>
To: Shraddha Barke <shraddha.6596@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/5] Staging: iio: cdc: ad7150: Prefer using the BIT macro
Date: Mon, 4 Jan 2016 12:17:20 +0000 [thread overview]
Message-ID: <568A62D0.8090907@kernel.org> (raw)
In-Reply-To: <1451388451-10342-5-git-send-email-shraddha.6596@gmail.com>
On 29/12/15 11:27, Shraddha Barke wrote:
> Replace bit shifting on 1 with the BIT(x) macro
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Applied.
> ---
> drivers/staging/iio/cdc/ad7150.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index e8d0ff2..0b934f7 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -21,8 +21,8 @@
> */
>
> #define AD7150_STATUS 0
> -#define AD7150_STATUS_OUT1 (1 << 3)
> -#define AD7150_STATUS_OUT2 (1 << 5)
> +#define AD7150_STATUS_OUT1 BIT(3)
> +#define AD7150_STATUS_OUT2 BIT(5)
> #define AD7150_CH1_DATA_HIGH 1
> #define AD7150_CH2_DATA_HIGH 3
> #define AD7150_CH1_AVG_HIGH 5
> @@ -36,7 +36,7 @@
> #define AD7150_CH2_TIMEOUT 13
> #define AD7150_CH2_SETUP 14
> #define AD7150_CFG 15
> -#define AD7150_CFG_FIX (1 << 7)
> +#define AD7150_CFG_FIX BIT(7)
> #define AD7150_PD_TIMER 16
> #define AD7150_CH1_CAPDAC 17
> #define AD7150_CH2_CAPDAC 18
>
next prev parent reply other threads:[~2016-01-04 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 11:27 [PATCH 0/5] Staging: iio: cdc: Checkpatch cleanups Shraddha Barke
2015-12-29 11:27 ` [PATCH 1/5] Staging: iio: cdc: ad7746: Prefer using the BIT macro Shraddha Barke
2016-01-04 12:00 ` Jonathan Cameron
2015-12-29 11:27 ` [PATCH 2/5] Staging: iio: cdc: ad7152: " Shraddha Barke
2016-01-04 12:02 ` Jonathan Cameron
2015-12-29 11:27 ` [PATCH 3/5] Staging: iio: cdc: ad7152: Fix alignment should match open parenthesis Shraddha Barke
2016-01-04 12:05 ` Jonathan Cameron
2015-12-29 11:27 ` [PATCH 4/5] Staging: iio: cdc: ad7150: Prefer using the BIT macro Shraddha Barke
2016-01-04 12:17 ` Jonathan Cameron [this message]
2015-12-29 11:27 ` [PATCH 5/5] Staging: iio: cdc: ad7150: Fix alignment should match open parenthesis Shraddha Barke
2016-01-04 12:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A62D0.8090907@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.