From: Jonathan Cameron <jic23@kernel.org>
To: Shraddha Barke <shraddha.6596@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: Anyone working on iio/cdc?
Date: Mon, 4 Jan 2016 12:36:34 +0000 [thread overview]
Message-ID: <568A6752.8010807@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1512300036010.23203@shraddha-370R4E-370R4V-370R5E-3570RE-370R5V>
On 29/12/15 19:07, Shraddha Barke wrote:
> Hello all,
> I'm helping Greg do cleanup of drivers in the staging directory as part
> of Outreachy intern program.
> I've sent out checkpatch patches for iio/cdc, meanwhile could you suggest
> what other tasks are left to be done so that iio/cdc can be moved out of
> staging?
>
> Kind Regards,
>
> Shraddha
I'll leave this one mostly to Lars to answer.
A quick glance at one of the drivers ad7150 - suggests the main issue
is one of ABI that we don't currently have and of conforming to what what
we do have!
The events on these are 'interesting' as they are adaptive in that we
are looking at a threshold on the absolute value (rather than a ROC)
but the threshold is adapting based on more or less a moving average
(with the timeout quirk)
This type of event needs to be fully described in some fashion...
We do have thresh_adaptive which is used in this driver, but it's not
properly documented so that would be a good start!
The trick is then to define the ABI to describe how the threshold is
adapting and the controls on it.
I don't think the current ABI for this description is specific or detailed enough..
Timeout is the 'unusual' control parameter. Hmm. Naming is tricky on this
one.
Perhaps _thresh_tracking_timeout so we'd end up with something like.
in_capacitance0_threshold_adaptive_thresh_tracking_timeout as a value in seconds.
Jonathan
prev parent reply other threads:[~2016-01-04 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 19:07 Anyone working on iio/cdc? Shraddha Barke
2016-01-04 12:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A6752.8010807@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.