Re: [PATCH v3 1/7] drm/exynos: rename zpos to index

From: Inki Dae <inki.dae@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v3 1/7] drm/exynos: rename zpos to index
Date: Mon, 04 Jan 2016 21:42:59 +0900	[thread overview]
Message-ID: <568A68D3.6080806@samsung.com> (raw)
In-Reply-To: <56812C60.2070209@samsung.com>

Hi Marek,

2015년 12월 28일 21:34에 Marek Szyprowski 이(가) 쓴 글:
> Hello,
> 
> On 2015-12-24 09:15, Inki Dae wrote:
>> Seems this patch could be more cleaned up.
>>
>> Each ctx object of each crtc driver has its own plane config object which includes already zpos value.
>> So I think we wouldn't need to keep zpos of the plane config and index of the plane object.
>> How about removing index from exynos plane structure and using zpos of exynos plane config structure instead?
>>
>> Below patch can be applied on top of your patch,
> 
> If you want I can move 'index' entry to config object, but the initial zpos value
> should also be there. Please note that index is not always equal to the initial zpos
> and having initial zpos configurable is also needed. There were already concerns if
> mixer's dedicated video plane should be below or above the primary gfx plane in the
> default configuration.

Merged all patches.

Thanks,
Inki Dae

> 
>> (...)
> 
> Best regards
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel