From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 04 Jan 2016 13:48:48 +0000 Subject: Re: [patch] drm/etnaviv: unlock on error in etnaviv_gem_get_iova() Message-Id: <568A7840.6020205@users.sourceforge.net> List-Id: References: <20160104131024.GA13563@mwanda> In-Reply-To: <20160104131024.GA13563@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dan Carpenter , Lucas Stach Cc: Russell King , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org > We have to drop a lock before returning -ENOMEM here. >=20 > Fixes: a8c21a5451d8 ('drm/etnaviv: add initial etnaviv DRM driver') > Signed-off-by: Dan Carpenter >=20 > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etna= viv/etnaviv_gem.c > index 8d6f859..9f77c3b 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -305,8 +305,10 @@ int etnaviv_gem_get_iova(struct etnaviv_gpu *gpu, > mapping =3D etnaviv_gem_get_vram_mapping(etnaviv_obj, NULL); > if (!mapping) { > mapping =3D kzalloc(sizeof(*mapping), GFP_KERNEL); > - if (!mapping) > - return -ENOMEM; > + if (!mapping) { > + ret =3D -ENOMEM; > + goto out; > + } > =20 > INIT_LIST_HEAD(&mapping->scan_node); > mapping->object =3D etnaviv_obj; How do you think about to reuse the jump label "unlock" there like it is used in other source files? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drive= rs/gpu/drm/etnaviv/etnaviv_gem.c?id=A8c21a5451d831e67b7a6fb910f9ca8bc7b4355= 4#n263 Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [patch] drm/etnaviv: unlock on error in etnaviv_gem_get_iova() Date: Mon, 4 Jan 2016 14:48:48 +0100 Message-ID: <568A7840.6020205@users.sourceforge.net> References: <20160104131024.GA13563@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.web.de (mout.web.de [212.227.17.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6075C6E489 for ; Mon, 4 Jan 2016 05:49:04 -0800 (PST) In-Reply-To: <20160104131024.GA13563@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Lucas Stach Cc: Russell King , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org PiBXZSBoYXZlIHRvIGRyb3AgYSBsb2NrIGJlZm9yZSByZXR1cm5pbmcgLUVOT01FTSBoZXJlLgo+ IAo+IEZpeGVzOiBhOGMyMWE1NDUxZDggKCdkcm0vZXRuYXZpdjogYWRkIGluaXRpYWwgZXRuYXZp diBEUk0gZHJpdmVyJykKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVu dGVyQG9yYWNsZS5jb20+Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9ldG5hdml2 L2V0bmF2aXZfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXRuYXZpdi9ldG5hdml2X2dlbS5jCj4g aW5kZXggOGQ2Zjg1OS4uOWY3N2MzYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXRu YXZpdi9ldG5hdml2X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V0bmF2aXYvZXRuYXZp dl9nZW0uYwo+IEBAIC0zMDUsOCArMzA1LDEwIEBAIGludCBldG5hdml2X2dlbV9nZXRfaW92YShz dHJ1Y3QgZXRuYXZpdl9ncHUgKmdwdSwKPiAgCW1hcHBpbmcgPSBldG5hdml2X2dlbV9nZXRfdnJh bV9tYXBwaW5nKGV0bmF2aXZfb2JqLCBOVUxMKTsKPiAgCWlmICghbWFwcGluZykgewo+ICAJCW1h cHBpbmcgPSBremFsbG9jKHNpemVvZigqbWFwcGluZyksIEdGUF9LRVJORUwpOwo+IC0JCWlmICgh bWFwcGluZykKPiAtCQkJcmV0dXJuIC1FTk9NRU07Cj4gKwkJaWYgKCFtYXBwaW5nKSB7Cj4gKwkJ CXJldCA9IC1FTk9NRU07Cj4gKwkJCWdvdG8gb3V0Owo+ICsJCX0KPiAgCj4gIAkJSU5JVF9MSVNU X0hFQUQoJm1hcHBpbmctPnNjYW5fbm9kZSk7Cj4gIAkJbWFwcGluZy0+b2JqZWN0ID0gZXRuYXZp dl9vYmo7CgpIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIHJldXNlIHRoZSBqdW1wIGxhYmVsICJ1 bmxvY2siIHRoZXJlCmxpa2UgaXQgaXMgdXNlZCBpbiBvdGhlciBzb3VyY2UgZmlsZXM/Cmh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0L25leHQvbGludXgtbmV4dC5n aXQvdHJlZS9kcml2ZXJzL2dwdS9kcm0vZXRuYXZpdi9ldG5hdml2X2dlbS5jP2lkPWE4YzIxYTU0 NTFkODMxZTY3YjdhNmZiOTEwZjljYThiYzdiNDM1NTQjbjI2MwoKUmVnYXJkcywKTWFya3VzCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==