From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] tools: make flask utils build unconditional Date: Mon, 4 Jan 2016 08:14:23 -0600 Message-ID: <568A7E3F.9020108@cardoe.com> References: <1450759603-24249-1-git-send-email-cardoe@cardoe.com> <20160104122805.GG9423@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4261499994412142093==" Return-path: In-Reply-To: <20160104122805.GG9423@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4261499994412142093== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UViT93O9RAO8XMSUedmWSQgP8QMIxUHKa" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UViT93O9RAO8XMSUedmWSQgP8QMIxUHKa Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/4/16 6:28 AM, Wei Liu wrote: > On Mon, Dec 21, 2015 at 10:46:43PM -0600, Doug Goldstein wrote: >> The flask utilities only have dependencies on libxc so there's no >> downside to always building it. Distros and projects based on Xen can >> put these utilities into a different package and not install them for >> everyone. Prior to this change FLASK_ENABLE needs to be a top level >> variable however after this change FLASK_ENABLE only affects xen/. >> >> Signed-off-by: Doug Goldstein >=20 > While it is true about the dependency, enabling flask build > unconditionally in toolstack will leave a xenpolicy-$VERSION installed > in /boot. Not sure how that will be useful to Xen without flask support= =2E >=20 > It is true that packager can pick that into separate package, but for > people installing from source, this might be a bit confusing. >=20 > Wei. Wei, This is actually not correct. The installation of that file is controlled by the ./configure script with --enable-xsmpolicy and --disable-xsmpolicy. This patch just makes the utilities be unconditionally built. -- Doug >=20 >> --- >> tools/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/Makefile b/tools/Makefile >> index 820ca40..2f773fd 100644 >> --- a/tools/Makefile >> +++ b/tools/Makefile >> @@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk >> SUBDIRS-y :=3D >> SUBDIRS-y +=3D include >> SUBDIRS-y +=3D libxc >> -SUBDIRS-$(FLASK_ENABLE) +=3D flask >> +SUBDIRS-y +=3D flask >> SUBDIRS-y +=3D xenstore >> SUBDIRS-y +=3D misc >> SUBDIRS-y +=3D examples >> --=20 >> 2.4.10 >> --=20 Doug Goldstein --UViT93O9RAO8XMSUedmWSQgP8QMIxUHKa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWin5CXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUNUAP/j/m9Dcmlb0mIHtwZOCbF128 fTT1/nBCBzIODCXO0vl6Ccoq01VRxUCBTlDUi8E3RAXPverKPN7TMFeiSXGAtDJo y08Finfz2jDZfEsrYyraXXerkvnFdv2tGRwPJPriWQ98iza97wugV+chdsQ2K2q0 lBvhX5pYBb21gv0zpTX6he4z2Dp/9XZ9QWoLpTUjqfQ19JY1/fUbxXlpR/NTsaKg wtE+vHDkyWOJyVJELDWSNKC/pQgvOgeWuKOBjrq9uHi2j498tg2pdP81D3HSFUbf aQkkUdOn+gmYQwEoqY+OxHvLVaG5+a/1pqZnWKkfss3Llz0ll+XAP2L0xzVEqkD7 ersEt3V+pUhqCKgUPxCwNwKafIdDlQWWdrUmFRNGvQwS1KfUO+RcZqI6jiTVoeyu gP3zjzeqt+sCZQ9XmxxkBrowYYIJA+6A/NjVPZgVTumbSgeAxo2JdwMNl71WDLZt hcBT0x58ElXK+kTcdWb0ntBihs7eRP4Gor1Ll+//zqv6+lL096jR4qTBSDKChH6I lhbofvjXC23ZoQovR2zz0fS6wEoImoFYG65ULGDjJgoePy6UXk7kik1ddLAs6zX1 lxEAYReh34OD5PnKTo6HxjkQIhvmBgnmjJBrPRnyC1igjXDpBrIXzrRiyEW5vaps VPjjRJeFW9J0HcgDvIdl =m9cT -----END PGP SIGNATURE----- --UViT93O9RAO8XMSUedmWSQgP8QMIxUHKa-- --===============4261499994412142093== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4261499994412142093==--