From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Gabriel Feceoru <gabriel.feceoru@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Add RPM references in the *_get_hw_state functions
Date: Mon, 4 Jan 2016 15:19:48 +0100 [thread overview]
Message-ID: <568A7F84.5000205@linux.intel.com> (raw)
In-Reply-To: <1451577127-3197-1-git-send-email-gabriel.feceoru@intel.com>
Hey,
Op 31-12-15 om 16:52 schreef Gabriel Feceoru:
> This gets rid of errors like:
>
> [ 906.286213] ------------[ cut here ]------------
> [ 906.286233] WARNING: CPU: 0 PID: 12252 at drivers/gpu/drm/i915/intel_drv.h:1457 gen6_read32+0x1ca/0x1e0 [i915]()
> [ 906.286234] RPM wakelock ref not held during HW access
> [ 906.286235] Modules linked in:
> [ 906.286236] snd_hda_intel i915 drm_kms_helper drm msr snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec snd_hwdep x86_pkg_temp_thermal snd_hda_core i2c_algo_bit ehci_pci syscopyarea sysfillrect sysimgblt fb_sys_fops ehci_hcd r8169 xhci_pci mii xhci_hcd video [last unloaded: drm]
> [ 906.286246] CPU: 0 PID: 12252 Comm: kms_pipe_crc_ba Tainted: G U W 4.4.0-rc6+ #45
> [ 906.286247] Hardware name: Dell Inc. Inspiron 3847/088DT1 , BIOS A06 01/15/2015
> [ 906.286248] ffffffffc022c098 ffff880210dbbae0 ffffffff813e0e4f ffff880210dbbb28
> [ 906.286250] ffff880210dbbb18 ffffffff8105f5f2 ffff8801fff40000 0000000000046040
> [ 906.286251] ffff8801fff49170 ffff8801fff49170 ffff8801fff40000 ffff880210dbbb78
> [ 906.286253] Call Trace:
> [ 906.286256] [<ffffffff813e0e4f>] dump_stack+0x44/0x55
> [ 906.286259] [<ffffffff8105f5f2>] warn_slowpath_common+0x82/0xc0
> [ 906.286261] [<ffffffff8105f67c>] warn_slowpath_fmt+0x4c/0x50
> [ 906.286270] [<ffffffffc007e29c>] ? drm_property_free_blob+0x8c/0xb0 [drm]
> [ 906.286280] [<ffffffffc01a32ea>] gen6_read32+0x1ca/0x1e0 [i915]
> [ 906.286283] [<ffffffff8172cd12>] ? mutex_lock+0x12/0x30
> [ 906.286294] [<ffffffffc01e0ef0>] hsw_ddi_wrpll_get_hw_state+0x40/0x50 [i915]
> [ 906.286304] [<ffffffffc01c3fa1>] intel_atomic_commit+0xd41/0x1740 [i915]
> [ 906.286312] [<ffffffffc008c597>] drm_atomic_commit+0x37/0x60 [drm]
> [ 906.286316] [<ffffffffc01373e6>] drm_atomic_helper_set_config+0x76/0xb0 [drm_kms_helper]
> [ 906.286323] [<ffffffffc008ac0a>] ? drm_modeset_lock_all_ctx+0x9a/0xb0 [drm]
> [ 906.286329] [<ffffffffc007b852>] drm_mode_set_config_internal+0x62/0x100 [drm]
> [ 906.286335] [<ffffffffc007fcfd>] drm_mode_setcrtc+0x3cd/0x4e0 [drm]
> [ 906.286339] [<ffffffffc0071762>] drm_ioctl+0x152/0x540 [drm]
> [ 906.286341] [<ffffffff8109d914>] ? __wake_up+0x44/0x50
> [ 906.286346] [<ffffffffc007f930>] ? drm_mode_setplane+0x1b0/0x1b0 [drm]
> [ 906.286348] [<ffffffff811dc844>] ? mntput+0x24/0x40
> [ 906.286350] [<ffffffff811bfe22>] ? __fput+0x172/0x1e0
> [ 906.286352] [<ffffffff811d0758>] do_vfs_ioctl+0x288/0x460
> [ 906.286353] [<ffffffff811bfece>] ? ____fput+0xe/0x10
>
> v2:
> Fixed return value in skl_ddi_pll_get_hw_state
>
> Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
>
Why do this in the get_hw_state functions? Seems more like it could be held by intel_modeset_check_state.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-04 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 12:45 [PATCH] drm/i915: Add RPM references in the *_get_hw_state functions Gabriel Feceoru
2015-12-31 13:20 ` ✗ failure: Fi.CI.BAT Patchwork
2015-12-31 15:52 ` [PATCH v2] drm/i915: Add RPM references in the *_get_hw_state functions Gabriel Feceoru
2016-01-04 14:19 ` Maarten Lankhorst [this message]
2016-01-04 15:05 ` Ville Syrjälä
2016-01-05 13:54 ` Daniel Vetter
2016-01-05 14:05 ` Marius Vlad
2016-01-07 8:38 ` Joonas Lahtinen
2015-12-31 16:20 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-04 12:55 ` [PATCH] drm/i915: Add RPM references in the *_get_hw_state functions Marius Vlad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568A7F84.5000205@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=gabriel.feceoru@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.