From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided Date: Mon, 4 Jan 2016 09:17:26 -0600 Message-ID: <568A8D06.2010901@amd.com> References: <1450820141-1720-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1450895221.30729.322.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1450895221.30729.322.camel@linux.intel.com> Sender: linux-i2c-owner@vger.kernel.org To: Andy Shevchenko , mika.westerberg@linux.intel.com, wsa@the-dreams.de Cc: jarkko.nikula@linux.intel.com, lho@apm.com, Ken.Xue@amd.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Hi Andy, On 12/23/2015 12:27 PM, Andy Shevchenko wrote: >> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c >> >b/drivers/i2c/busses/i2c-designware-platdrv.c >> >index 8ffc36b..04edd09 100644 >> >--- a/drivers/i2c/busses/i2c-designware-platdrv.c >> >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c > Can we introduce > > static int i2c_dw_plat_prepare_clk(struct dw_i2c_dev *i_dev, bool > prepare) > { > if (IS_ERR(i_dev->clk)) > return PTR_ERR(i_dev->clk); > > if (prepare) > /* REMOVEME: Yes, you have to check return value and this is one > benefit of this change */ > return clk_prepare_enable(i_dev->clk); > > clk_disable_unprepare(i_dev->clk); > return 0; > } > > and=E2=80=A6 > Yes, I think this change. I'll put this in the V4, and send out soon. Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbcADPRl (ORCPT ); Mon, 4 Jan 2016 10:17:41 -0500 Received: from mail-by2on0081.outbound.protection.outlook.com ([207.46.100.81]:26304 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751581AbcADPRi (ORCPT ); Mon, 4 Jan 2016 10:17:38 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided To: Andy Shevchenko , , References: <1450820141-1720-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1450895221.30729.322.camel@linux.intel.com> CC: , , , , , From: Suravee Suthikulpanit Message-ID: <568A8D06.2010901@amd.com> Date: Mon, 4 Jan 2016 09:17:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450895221.30729.322.camel@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR0301CA0016.namprd03.prod.outlook.com (25.162.113.154) To SN1PR12MB0448.namprd12.prod.outlook.com (25.162.105.141) X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0448;2:K3QWEsRldRafVvO3DRvP6KQeNTkaQmLnMJVUshjBspRF09YO/kdhehPy8lvYScP+Hdkt238Zmq2ic5dBtuDlNt/zBBac8vzaK7IxVmmNwhOQEk018qLQrzvYOlHcsYDxkJ/8S00zybmRMG6xrfsJZg==;3:3aLOP6MMXlZ7spN4L6V+RU9queLpXavuGk57lVUROXH3js+JQtrvjbVxqnUstPcpQtsZDFXpNrFBEP2eBJRgWR+opS++fdNv2dRTxw/qX7BAwMd+dgI1ipKjfR3gbdj7;25:CFcqxiJtIIixBr0VABOuZfRButsW4lcLFVLDKphxIsVvriB4NEAJp6MldNO0MuzLlijdI0EcrFzPwoa17BfCVU4ceEaByH1kZ+/h86OaartyGsGj5847gu3OFS6Ixpdl36ZIt/4/1aO94UZajHu537Nio+pZC/PgVmipg9iVtQsYH8GZjffqh/+dylKr4LhgvNNCOuWDFqU9Wmm849mlfOPGqVKeCT8+H9ajFUsw7ITR2ERkSVctYEnl8nXA3Qq1xCiR6h3wA/FNSoMif0dDYQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0448; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0448;20:gZrtuwuyJbQBZg0IZKBq+nCFPrxmR3BMffilLgWWCD2/V2ZapLk09wCwC8hBwtQTQdnac8dxBk7JYPdSQn/WNsUWOmaEvijW97TuRJcWhjxoPW7hS3HNjdrkQ+hJ/V0GN6PnJ3s4I1IUkd0/crnRYVc9KuG3hM5RUY9gAz4elmdhPiUkzx7Xf7yAK/zj0FQlkbt1IFnRvBtOoNLxqU5bwwhbV/ZySsiTwroZqmEBJbOyuqPHBcoyvvXZWAi6sAzdMpG/xQ8tBtPxbAi/1Sm+kNzjAGuTvSrYwNN/P/Gc6THg5xlf1c1btU4oLOYQyrEiKUll9XfYsqeCiKFRkzI70hgyKdqSiNwGUGqphdtEMAP/Izd+/ouRaL2uF4g5h7a/vt9oi2zU5ZrJRwXgK9WbOLRHjZwD6zY8AmHYbk9Oq3n179ogfWa93jCZXrufCAurlZQrSAKrxFE7uTZNccWptPwAmUwE0Nt0WwRGPHr+c5W1shqudnqgkDN7J5VOMz3/;4:+rIdNXkeaCfLHY7Iu0AO7sbpoimdy1xV48IB89Q3k6+lDtcQH3/KkgQYY/tiJO+2pq5wAjNVv0gjFidADGAC98CTshWNdVbY3MbNqXuEaI/7Tvxbc/O8fwe4lES88fl04Yk8auUQ8nQlwZQ4lDII8TxaqeeyEBx7KxS3cqCgA56KUg5DxwqbPa5b3A1GEc+zAqdaLoAjwmOGNAnetr7pXHt8n+mh9DpdegkPNYqa0/Z6VUCFCQ/Y5pT8sDatyF6ctaR3IXAFQAYpmylXBzDsTxqEy+owJTd1Y5bJTirI8NUv1fK/yvPlH+l7ZCbSqxfNvXgNuLqdkZFy+ysqoeEoxLPPlWz7QtWjtxHxJaZ+tjgFly9kObj3308tHyq6Y7Xm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:SN1PR12MB0448;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0448; X-Forefront-PRVS: 08118EFC2B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(377454003)(24454002)(189002)(479174004)(199003)(33656002)(5001960100002)(83506001)(4326007)(42186005)(105586002)(80316001)(65806001)(59896002)(6116002)(1096002)(2201001)(5004730100002)(3846002)(586003)(66066001)(101416001)(65956001)(122386002)(47776003)(64126003)(97736004)(54356999)(50466002)(87266999)(86362001)(5008740100001)(50986999)(23676002)(81156007)(87976001)(4001350100001)(40100003)(106356001)(36756003)(76176999)(92566002)(77096005)(65816999)(5001770100001)(189998001)(2950100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0448;H:[10.236.18.254];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNDQ4OzIzOmhJeEFtN2lJc1llTjJXaDNYcU9zTXFDZjlj?= =?utf-8?B?NzFKd3FFR2RWSjFaNzRiQUJTY01FeTBlN3ZnR2RFdExNVTFwcVlKWjFYcXlR?= =?utf-8?B?UUFxckpPTm9MS2tsQTBYMFdFaTdkL05ab3Q3MFdyK29uWXkveDZkcHBMNkt2?= =?utf-8?B?WVk5UHFUY0s4R0tFN1ZVcTh5dkFZNmlUM1Rzb0hlM2pzTkNVdU1zajdNM2Ja?= =?utf-8?B?MURZMHFCYStDWCtvejc3RG5UZDMvTnFoRmY4bkNhUzJWTVdiTEZXaHJkRVlx?= =?utf-8?B?b3dqakpFSTEzZi8yZ1RKNTdpczlkY3hLTGpRaVFyNzVCdVdQTDNlajV1ZllK?= =?utf-8?B?L2ZVZEh3UWo1d1hhM0VwWXg0djVLNHI0dHViV1dwWGQ5ZklmamxYaGc5bXMy?= =?utf-8?B?a0lYUjZ3enc1Q3k3VzBacEZoelRsSzQ2WlorQ3dROEttOHlNZmxlWlh4Z3dU?= =?utf-8?B?RkZjbUNtbE80Y1RCWFUvaXlZWUQ1SytMSE9wTjFtQklBMnlzSUxQMW56b0Zy?= =?utf-8?B?TG1pSjNGdVUxcGtKaVQvVi9pRGJCdXhXM2dBN2NZUThHakJyTlN6WUVWVlRM?= =?utf-8?B?ZXJGdm42N1p3NnU3NkRVR3p5UUcwRlFWQTBNR1JJVkJpd1VQVEdDeEh0dkdV?= =?utf-8?B?L3J4aDFDbjB5SHphTmZ1YlZrakNDZFpYZjFyOWxDMUhERjhvV1ZBeTJxWUVM?= =?utf-8?B?ZkhKRXhVYThmZGlEZXR5TlFUTXZaRjRUekx1cFZqeEluOEtKTHFZYVNFbTQ4?= =?utf-8?B?aUJVUmhScTg5NlVGWCtKSCtTYmZrc0FueGx1TmtGT2pqS29NUi9WV0FKMzdI?= =?utf-8?B?cWRQVGNQMXhtUlNtSnFwVWJnL0V1VU5NeTNpUlNlemxzZGM2djhsdnJJNmRP?= =?utf-8?B?aFhTMEp0SnV2UTFid1U0ZVlTaTk3RHAzcC84bDh5SjR2b2o5Zm5scWpoYkxL?= =?utf-8?B?b216RDRCZEdZZmp5MmgxbkpSclBkREdxUlB1NzljK2xEdXpQeFhnSWxBTk9h?= =?utf-8?B?OTNFMy81U3g0aGRXU1Q0S3lEZGNGb1RDaEJ5TnVmcEMzWW5BNCt1cWJCL1dP?= =?utf-8?B?QkVPaXU5aG5KNXJtaUZ4dklSaWdjUVFOSDA4NWdCTU8vQnpGTWdQS2tnbUNX?= =?utf-8?B?N2ZTVjVlYWdLRU5kVXNyM29Xcis1MVBuNEtmK1NxQlJValRrZUhOQlp2VWU3?= =?utf-8?B?a1F6Y2w4V0diZWovSXoza1ljVE5jek1qVWJoeWtUREpQeEhmdjNObFU4bkZH?= =?utf-8?B?NWxUKzF5dlpnZlVDdjRqelNQQThXWjlRTENtamlLZHUrWXBDb0dzMEFBVEs3?= =?utf-8?B?RHk2R1N0VjNYblFxSmsvbWptZVB5KytTWlZramhReDZhMVFNc0I2TWdCcEtO?= =?utf-8?B?Y1pkMzV1TUFFQWxJUUd4d0tDRjM0TVJjT09lKzdaRkZxb0lSaG55NG1JNlhk?= =?utf-8?B?KzdWcW5icTdvUlBxYXFjZkEzOFZ0KzhGRnR6NmloVmU2NEZBK1U3cTN3RFFQ?= =?utf-8?B?RE0yUUQ5bGNaSzM0YkVLdkpNb0ZaNFUxK3JyeW1tMFg4K1N6T2Y1aHh2UGor?= =?utf-8?B?R1oxV3RjYmpOY2JHaWpRNmpDaGtySnpMcHVWYkZYbFE5VWhxOUVXRHVSNjIr?= =?utf-8?B?WXp0dzFHMEp6YjROZWdRb2FnTVlWdjh1SkxhM0RMVm5xYlFsQUdIcFVFS08v?= =?utf-8?Q?J3tE/0is/thlPDwIC0=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0448;5:BzjFI56A+VFO+yD/y9WvpffXo1e1ihDjaRjm7GTLPN1UDTch6Y8G3MiQFEo0GWLoeTTgiiAfHSblsM9hrz2xfxhv2EAZI7NKIGPi/orrtDXYdsNdrarBSsOZ8Iiiivr1zGRV4covCANq1ggSO10YSA==;24:pOQ4xKJbi4ynxG2f6QK6+E5lpqSRDxQJAAbyD0GQDz3e+KcuiR/OXH2nR34j6mKVdle8QA2roMEDEi+rny4T5LN1RoP7f5ilifvyADAkLLM=;20:XQAFgNj73/mJhor42gjbyXtTocyEF72cWjO9yFAak15OSvgZh7qg43AAruAS9qh0Cy2ATaBXHNAPmbevWZT188gJY28RxPqywrnoezk+I5/gIqKRz0nWLst4dn2r5BtP2Fi4JzUMQu42ES9hVzU5vUXMMW2baXZrYUouRSUADjwE7wVx2JDwbY6/mcISR6XuIT1VaYjrhs+OweXswyWfUeyfT7FNP9av3IBNU/F+UVe7R/IlNAYj3t5VTyN4h08Z X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2016 15:17:34.5151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0448 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 12/23/2015 12:27 PM, Andy Shevchenko wrote: >> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c >> >b/drivers/i2c/busses/i2c-designware-platdrv.c >> >index 8ffc36b..04edd09 100644 >> >--- a/drivers/i2c/busses/i2c-designware-platdrv.c >> >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c > Can we introduce > > static int i2c_dw_plat_prepare_clk(struct dw_i2c_dev *i_dev, bool > prepare) > { > if (IS_ERR(i_dev->clk)) > return PTR_ERR(i_dev->clk); > > if (prepare) > /* REMOVEME: Yes, you have to check return value and this is one > benefit of this change */ > return clk_prepare_enable(i_dev->clk); > > clk_disable_unprepare(i_dev->clk); > return 0; > } > > and… > Yes, I think this change. I'll put this in the V4, and send out soon. Suravee