From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH OSSTEST] Add a weekly coverity flight Date: Mon, 4 Jan 2016 16:55:47 +0000 Message-ID: <568AA413.2030605@citrix.com> References: <1450179958-11426-1-git-send-email-ian.campbell@citrix.com> <22154.41506.565155.275702@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22154.41506.565155.275702@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Ian Campbell Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/01/16 16:47, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] Add a weekly coverity flight"): >> Move collectversions into Osstest::BuildSupport rather than >> duplicating with ts-xen-build (nothing else is really duplicated) > This could profitably be split into a separate patch IMO. > >> For the cr-* integration we treat branch=coverity as a special case of >> tree=xen. I didn't think tree=coverity made much sense, and would >> probably reach tendrils into lots of other places (such as the >> invocations of check_tested). >> >> TODO: How to pick $c{CoverityEmail}, needs to be a real email which is >> in coverity project (which security@xen.org used here is not) > I don't have an answer to this but perhaps osstest-admin@xenproject ? > Or will it get lots of annoying output ? (We could filter it to make > it go to osstest-output I guess...) > >> +CoverityEmail security@xen.org >> +CoverityTools cov-analysis-linux64-7.7.0.4.tar.gz > This file needs a DEPLOYMENT NOTE I think. > > The rest of this looks OK. A review from Andrew Cooper might be > worthwhile ? I don't speak much perl, nor know the internals of OSSTest. However, the snippets of shell for building look correct. ~Andrew