All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Tejun Heo <tj@kernel.org>
Cc: netdev@vger.kernel.org, cgroups@vger.kernel.org,
	shm@cumulusnetworks.com, roopa@cumulusnetworks.com
Subject: Re: [RFC PATCH net-next] net: Add l3mdev cgroup
Date: Mon, 4 Jan 2016 11:53:55 -0700	[thread overview]
Message-ID: <568ABFC3.3010803@cumulusnetworks.com> (raw)
In-Reply-To: <20160104175836.GA11668@mtj.duckdns.org>

Hi Tejun:

On 1/4/16 10:58 AM, Tejun Heo wrote:
> Please don't create any new controller whose sole purpose is
> identifying group membership.  Please take a look at how libxt_cgroup
> handles identification w/o creating a new controller.
>
>   http://lkml.kernel.org/g/1449527935-27056-1-git-send-email-tj@kernel.org
>

This controller applies a cgroup specific setting to tasks associated 
with an instance (similar to cpuset restricting tasks to specifics 
CPUs), so it is more than just identifying membership.

I looked at the commits referenced above and net/netfilter/xt_cgroup.c 
code in particular and I don't see how it applies to this use case. Can 
you elaborate?

Thanks,
David

  reply	other threads:[~2016-01-04 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 16:32 [RFC PATCH net-next] net: Add l3mdev cgroup David Ahern
     [not found] ` <1451925136-13327-1-git-send-email-dsa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2016-01-04 17:58   ` Tejun Heo
2016-01-04 18:53     ` David Ahern [this message]
     [not found]       ` <568ABFC3.3010803-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2016-01-04 18:59         ` Tejun Heo
     [not found]           ` <20160104185936.GA3807-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-01-04 19:17             ` David Ahern
2016-01-04 19:23               ` Tejun Heo
2016-01-04 19:59                 ` David Ahern
     [not found]                   ` <568ACF13.3030007-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2016-01-04 20:05                     ` Tejun Heo
     [not found]                       ` <20160104200518.GD3807-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-01-19 16:03                         ` Stephen Hemminger
2016-01-19 16:06                           ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568ABFC3.3010803@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=cgroups@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=shm@cumulusnetworks.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.