From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aGAcL-0006FM-Fp
	for qemu-devel@nongnu.org; Mon, 04 Jan 2016 14:16:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aGAcH-000463-F4
	for qemu-devel@nongnu.org; Mon, 04 Jan 2016 14:16:33 -0500
References: <1451928613-29476-1-git-send-email-mark.cave-ayland@ilande.co.uk>
	<alpine.LFD.2.20.1601050028160.19588@wniryva>
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-ID: <568AC4E3.8050101@ilande.co.uk>
Date: Mon, 4 Jan 2016 19:15:47 +0000
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.20.1601050028160.19588@wniryva>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset
 conversion for ATAPI devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: P J P <ppandit@redhat.com>
Cc: qemu-ppc@nongnu.org, jsnow@redhat.com, qemu-devel@nongnu.org, agraf@suse.de

On 04/01/16 19:04, P J P wrote:

> +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+
> |      /* Calculate current offset */
> | -    offset = (int64_t)(s->lba << 11) + s->io_buffer_index;
> | +    offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index;
> 
> Maybe ((int64_t)s->lba << 11) ? No parenthesis around s->lba.

Yes that works here too (perhaps I was just being over-cautious).
Alex/John, please let me know if you want me to resubmit.


ATB,

Mark.