Re: [PATCH] Makefile: Set CC/AR variable only if it doesn't have a value

[Arnout Vandecappelle <arnout.vandecappelle@essensium.com>]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

On 04-01-16 17:20, Khem Raj wrote:
>> On Jan 4, 2016, at 5:39 AM, Jeff Epler <jepler@unpythonic.net> wrote:
>> > 
>> > I believe the patch does not have the desired effect, because make(1)
>> > always sets CC automatically:
>> > 
>> > $ cat raj.mk
>> > CROSS_COMPILE=x86_64-linux-gnu-
>> > CC?=$(CROSS_COMPILE)gcc
>> > .PHONY: default
>> > default:
>> > 	@echo CC=$(CC)
>> > $ make -f raj.mk
>> > CC=cc
>> > 
>> > With your patch, those who specify CROSS_COMPILE, or for whom gcc and cc
>> > are different, will get different (worse) behavior.
> Right. I think if CC was used as such with out constructing out of CROSS_COMPILE
> in Makefile then my issue would be fixed too. However this would mean that cross compiling users
> now have to pass CC = <cross-compiler> themselves instead of CROSS_COMPILE prefix. Is that
> acceptable ?

 But what is really your issue? Even after this patch, you'll have to run

make CC=<path-to-clang> AR=<path-to-clang-ar>

and this will already override it in the current situation.


 Regards,
 Arnout


-- 
Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]