All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thor Thayer <tthayer@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>,
	Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: <dinh.linux@gmail.com>, <dougthompson@xmission.com>,
	<mchehab@osg.samsung.com>, <linux@arm.linux.org.uk>,
	<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support
Date: Mon, 4 Jan 2016 15:33:23 -0600	[thread overview]
Message-ID: <568AE523.7010905@opensource.altera.com> (raw)
In-Reply-To: <20160104210726.GS22941@pd.tnic>



On 01/04/2016 03:07 PM, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 02:55:43PM -0600, Dinh Nguyen wrote:
>> Right. So for us, if we build in SDRAM ECC unconditionally, there is a
>> requirement with the bootloader to turn on ECC and scrub the memory.
>
> Huh, how does a built-in piece of code cause the bootloader to do
> something?!?
>
> And how would the bootloader know what's in the kernel? The bootloader
> runs first and hands off to the kernel...
>
Hi Boris,

The decision about ECC or non-ECC SDRAM is made before building the 
Linux image and must be matched to the appropriate bootloader (ECC or 
non-ECC).

If ECC is desired for SDRAM, the bootloader enables SDRAM ECC and then 
initializes the memory contents (scrub) before the Linux image is loaded 
into SDRAM.

The ECC syndromes are calculated and stored in SDRAM only when SDRAM ECC 
is enabled and the SDRAM data is written (in the bootloader case, this 
is the Linux image). If we suddenly switched ECC on during Linux 
initialization, we'd be flooded with ECC errors since the ECC syndromes 
won't match the data for the Linux image.

The scrubbing process takes more time to boot which some of our 
customers don't want. This is what Dinh was referring to.

  reply	other threads:[~2016-01-04 21:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 20:38 [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support dinguyen
2015-11-19 18:34 ` Borislav Petkov
2016-01-04 17:17   ` Dinh Nguyen
2016-01-04 19:46     ` Borislav Petkov
2016-01-04 20:04       ` Dinh Nguyen
2016-01-04 20:30         ` Borislav Petkov
2016-01-04 20:46           ` Dinh Nguyen
2016-01-04 20:59             ` Borislav Petkov
2016-01-04 20:55               ` Dinh Nguyen
2016-01-04 21:07                 ` Borislav Petkov
2016-01-04 21:33                   ` Thor Thayer [this message]
2016-01-04 22:01                     ` Borislav Petkov
2016-01-04 23:42                       ` Thor Thayer
2016-01-05 10:58                         ` Borislav Petkov
2016-01-05 20:37                           ` Thor Thayer
2016-01-05 21:09                             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568AE523.7010905@opensource.altera.com \
    --to=tthayer@opensource.altera.com \
    --cc=bp@alien8.de \
    --cc=dinguyen@opensource.altera.com \
    --cc=dinh.linux@gmail.com \
    --cc=dougthompson@xmission.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.