All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fakeroot: fix build when libcap-dev is installed
Date: Mon, 4 Jan 2016 22:36:37 +0100	[thread overview]
Message-ID: <568AE5E5.3020307@mind.be> (raw)
In-Reply-To: <568AB024.40104@mind.be>

On 04-01-16 18:47, Arnout Vandecappelle wrote:
>  Hi Luca,
> 
> On 04-01-16 13:01, Luca Ceresoli wrote:
>> On an Ubuntu host, and probably several other build hosts,
>> host-fakeroot fails building when libcap-dev is installed.
>>
>> Error message:
>>
>>   libfakeroot.c:1646:9: error: conflicting types for 'setxattr'
>>    ssize_t setxattr(const char *path, const char *name, void *value, size_t size, int flags)
>>            ^
>>   In file included from /usr/include/sys/capability.h:30:0,
>>                    from libfakeroot.c:131:
>>   /usr/include/x86_64-linux-gnu/sys/xattr.h:39:12: note: previous declaration of 'setxattr' was here
>>    extern int setxattr (const char *__path, const char *__name,
>>               ^
>>
>> To reproduce the bug:
>>
>>   make defconfig && make host-fakeroot
>>
>> This is a fakeroot bug fixed in Debian since 1.20.1-1 [0]. Apply the
>> patch [1] to Buildroot as well.
> 
>  Are we sure this will not break again on other distros or older Debian/Ubuntu?

 I prefer Ricardo's alternative.

 We will have to pay attention however, if upstream (i.e. Debian?) releases a
new version, that we _don't_ take this patch along. Although I'm not sure if the
upstream patch really breaks the build on older systems, I haven't checked when
xattr.h has changed.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-01-04 21:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 12:01 [Buildroot] [PATCH] fakeroot: fix build when libcap-dev is installed Luca Ceresoli
2016-01-04 17:47 ` Arnout Vandecappelle
2016-01-04 21:36   ` Arnout Vandecappelle [this message]
2016-01-04 22:07     ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568AE5E5.3020307@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.