Re: [PATCH v2 2/3] base-files: create ${base_bindir} etc. instead of /bin, /sbin and /lib

[Matthias Schiffer <mschiffer@universe-factory.net>]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

On 01/04/2016 11:59 PM, Mark Hatle wrote:
> On 1/2/16 5:53 PM, Matthias Schiffer wrote:
>> These directories conflict with the symlinks created for merged-usr setups.
>>
>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>> ---
>> v2: create both ${base_libdir} and ${nonarch_base_libdir}
>>
>>  meta/recipes-core/base-files/base-files_3.0.14.bb | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> index b71d5c5..2af7ecd 100644
>> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> @@ -33,8 +33,8 @@ INHIBIT_DEFAULT_DEPS = "1"
>>  docdir_append = "/${P}"
>>  dirs1777 = "/tmp ${localstatedir}/volatile/tmp"
>>  dirs2775 = ""
>> -dirs755 = "/bin /boot /dev ${sysconfdir} ${sysconfdir}/default \
>> -           ${sysconfdir}/skel /lib /mnt /proc ${ROOT_HOME} /run /sbin \
>> +dirs755 = "${base_bindir} /boot /dev ${sysconfdir} ${sysconfdir}/default \
>> +           ${sysconfdir}/skel ${base_libdir} ${nonarch_base_libdir} /mnt /proc ${ROOT_HOME} /run ${base_sbindir} \
>>             ${prefix} ${bindir} ${docdir} /usr/games ${includedir} \
>>             ${libdir} ${sbindir} ${datadir} \
>>             ${datadir}/common-licenses ${datadir}/dict ${infodir} \
>>
> 
> I agree this new set looks correct.. but I'd like to see the corresponding
> change to fs-perms that sets the permissions and such for each of these new
> locations.
> 
> --Mark
> 

The current meta/files/fs-perms.txt doesn't mention any of /bin, /sbin
or /lib, and seemingly never did. I guess they could be added, but that
could also be done in a separate patch (and as I mentioned in another
mail, I'm not exactly a fan of the fs-perms concept, so I don't really
care.)

Matthias


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]