From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Tom Herbert <tom@herbertland.com>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH net-next] net: Implement fast csum_partial for x86_64
Date: Tue, 5 Jan 2016 00:51:37 +0100 [thread overview]
Message-ID: <568B0589.9010900@stressinduktion.org> (raw)
In-Reply-To: <CALx6S370tAh1g5q9trDuFxc84qOozT6XjdSKB94dvGRTUikfvA@mail.gmail.com>
On 05.01.2016 00:34, Tom Herbert wrote:
> On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote:
>> \...
>>> +402: /* Length 2, align is 1, 3, or 5 */
>>> + movb (%rdi), %al
>>> + movb 1(%rdi), %ah
>>
>> Looks like a movw (%rdi),%ax
>>
> Wouldn't that be an unaligned access?
Based on my knowledge (based on arch/x86/include/asm/unaligned.h) the
x86 architecture (and this code is specific for x86) can handle
unaligned access on its own.
Bye,
Hannes
next prev parent reply other threads:[~2016-01-04 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 23:22 [PATCH net-next] net: Implement fast csum_partial for x86_64 Tom Herbert
2016-01-04 22:17 ` Hannes Frederic Sowa
2016-01-04 22:36 ` Eric Dumazet
2016-01-04 23:34 ` Tom Herbert
2016-01-04 23:51 ` Hannes Frederic Sowa [this message]
2016-01-04 23:52 ` Eric Dumazet
2016-01-04 23:58 ` Tom Herbert
2016-01-05 3:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B0589.9010900@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.