From: Jia-Ju Bai <baijiaju1990@163.com>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
kvalo@codeaurora.org,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits
Date: Tue, 05 Jan 2016 09:27:47 +0800 [thread overview]
Message-ID: <568B1C13.9050900@163.com> (raw)
In-Reply-To: <CAGXE3d9tTr6hyOjh==Mn5tNQSy-hMBhxtmsWNY_tLgJqE=B38A@mail.gmail.com>
On 01/05/2016 12:50 AM, Helmut Schaa wrote:
> On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai<baijiaju1990@163.com> wrote:
>> The driver calls pci_set_mwi to enable memory-write-invalidate when it
>> is initialized, but does not call pci_clear_mwi when it is removed. Many
>> other drivers calls pci_clear_mwi when pci_set_mwi is called, such as
>> r8169, 8139cp and e1000.
>>
>> This patch adds pci_clear_mwi in error handling and removal procedure,
>> which can fix the problem.
>>
>> Signed-off-by: Jia-Ju Bai<baijiaju1990@163.com>
> Looks good to me.
> Does this fix any actual issue?
> If yes it might we worth to mention it in the commit message.
> Helmut
>
Lacking pci_clear_mwi may cause a resource-release omission,
but this omission may not cause obvious issues.
For reliability, it is better to add pci_clear_mwi in the driver.
Many other drivers do so, such as r8169, 8139cp and e1000.
Jia-Ju Bai
next prev parent reply other threads:[~2016-01-05 1:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 7:55 [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits Jia-Ju Bai
2016-01-04 16:50 ` Helmut Schaa
2016-01-05 1:27 ` Jia-Ju Bai [this message]
2016-01-05 10:17 ` Helmut Schaa
2016-01-07 9:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B1C13.9050900@163.com \
--to=baijiaju1990@163.com \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.