diff for duplicates of <568B7F6A.3000607@rock-chips.com> diff --git a/a/1.txt b/N1/1.txt index 84f7b02..a4ebd52 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,21 +1,21 @@ Hi, Alessandro: -On 2016年01月04日 21:59, Alessandro Zummo wrote: +On 2016=E5=B9=B401=E6=9C=8804=E6=97=A5 21:59, Alessandro Zummo wrote: > On Mon, 4 Jan 2016 10:45:46 +0100 > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: -> +>=20 >> I'm not sure it is useful to do that renaming. It is usual to have one >> driver that supports multiple chips named with the forst chip it >> supported. >> >> Also, what would happen if for example rk855 is not compatible at all >> with the previous implementations? -> +>=20 > Alexandre is absolutely right. There's no need to rename a driver, > it would just piss off people who are used to that name and > have it in their scripts. Like when your eth0 gets renamed > to some obscure enXXX <g>. -> +>=20 You and Alexandre are right. The rename is just make the driver more readable, i.e. let people know this driver suit for more PMIC no just @@ -31,17 +31,17 @@ Please review this code: -static int rk808_rtc_probe(struct platform_device *pdev) +static int rk8xx_rtc_probe(struct platform_device *pdev) { -- struct rk808 *rk808 = dev_get_drvdata(pdev->dev.parent); +- struct rk808 *rk808 =3D dev_get_drvdata(pdev->dev.parent); ... -+ struct i2c_client *client = to_i2c_client(pdev->dev.parent); ++ struct i2c_client *client =3D to_i2c_client(pdev->dev.parent); ... -- rk808_rtc->rk808 = rk808; -+ rk8xx_rtc->regmap = devm_regmap_init_i2c(client, +- rk808_rtc->rk808 =3D rk808; ++ rk8xx_rtc->regmap =3D devm_regmap_init_i2c(client, + &rk8xx_rtc_regmap_config); ... -+ rk8xx_rtc->i2c = client; ++ rk8xx_rtc->i2c =3D client; Old driver have struct rk808 pointer, which defined on include/linux/mfd/rk808.h @@ -57,3 +57,16 @@ change? Thanks! Huang, Tao + +--=20 +--=20 +You received this message because you are subscribed to "rtc-linux". +Membership options at http://groups.google.com/group/rtc-linux . +Please read http://groups.google.com/group/rtc-linux/web/checklist +before submitting a driver. +---=20 +You received this message because you are subscribed to the Google Groups "= +rtc-linux" group. +To unsubscribe from this group and stop receiving emails from it, send an e= +mail to rtc-linux+unsubscribe@googlegroups.com. +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 53998f6..d36124f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020160104094546.GB32724@piout.net\0" "ref\020160104145938.6c053b5a@linux.lan.towertech.it\0" "From\0Huang, Tao <huangtao@rock-chips.com>\0" - "Subject\0Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c\0" + "Subject\0[rtc-linux] Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c\0" "Date\0Tue, 5 Jan 2016 16:31:38 +0800\0" "To\0Alessandro Zummo <a.zummo@towertech.it>" " Alexandre Belloni <alexandre.belloni@free-electrons.com>\0" @@ -17,22 +17,22 @@ "b\0" "Hi, Alessandro:\n" "\n" - "On 2016\345\271\26401\346\234\21004\346\227\245 21:59, Alessandro Zummo wrote:\n" + "On 2016=E5=B9=B401=E6=9C=8804=E6=97=A5 21:59, Alessandro Zummo wrote:\n" "> On Mon, 4 Jan 2016 10:45:46 +0100\n" "> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:\n" - "> \n" + ">=20\n" ">> I'm not sure it is useful to do that renaming. It is usual to have one\n" ">> driver that supports multiple chips named with the forst chip it\n" ">> supported.\n" ">>\n" ">> Also, what would happen if for example rk855 is not compatible at all\n" ">> with the previous implementations?\n" - "> \n" + ">=20\n" "> Alexandre is absolutely right. There's no need to rename a driver,\n" "> it would just piss off people who are used to that name and\n" "> have it in their scripts. Like when your eth0 gets renamed\n" "> to some obscure enXXX <g>.\n" - "> \n" + ">=20\n" "\n" "You and Alexandre are right. The rename is just make the driver more\n" "readable, i.e. let people know this driver suit for more PMIC no just\n" @@ -48,17 +48,17 @@ "-static int rk808_rtc_probe(struct platform_device *pdev)\n" "+static int rk8xx_rtc_probe(struct platform_device *pdev)\n" " {\n" - "-\tstruct rk808 *rk808 = dev_get_drvdata(pdev->dev.parent);\n" + "-\tstruct rk808 *rk808 =3D dev_get_drvdata(pdev->dev.parent);\n" "\t...\n" - "+\tstruct i2c_client *client = to_i2c_client(pdev->dev.parent);\n" + "+\tstruct i2c_client *client =3D to_i2c_client(pdev->dev.parent);\n" "\n" "\t...\n" "\n" - "-\trk808_rtc->rk808 = rk808;\n" - "+\trk8xx_rtc->regmap = devm_regmap_init_i2c(client,\n" + "-\trk808_rtc->rk808 =3D rk808;\n" + "+\trk8xx_rtc->regmap =3D devm_regmap_init_i2c(client,\n" "+\t\t\t\t\t &rk8xx_rtc_regmap_config);\n" "\t...\n" - "+\trk8xx_rtc->i2c = client;\n" + "+\trk8xx_rtc->i2c =3D client;\n" "\n" "Old driver have struct rk808 pointer, which defined on\n" "include/linux/mfd/rk808.h\n" @@ -73,6 +73,19 @@ "change?\n" "\n" "Thanks!\n" - Huang, Tao + "Huang, Tao\n" + "\n" + "--=20\n" + "--=20\n" + "You received this message because you are subscribed to \"rtc-linux\".\n" + "Membership options at http://groups.google.com/group/rtc-linux .\n" + "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" + "before submitting a driver.\n" + "---=20\n" + "You received this message because you are subscribed to the Google Groups \"=\n" + "rtc-linux\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an e=\n" + "mail to rtc-linux+unsubscribe@googlegroups.com.\n" + For more options, visit https://groups.google.com/d/optout. -d03f7281f94c44484f29b23109c32551fbf0f1179d871b1601d5f40343f4a486 +5a843305bf26e93e0e07e742ee253783608f312f65cec9c838ba54e56cd6b682
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.