From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <alexandre.torgue@st.com>
Subject: Re: [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000
Date: Tue, 5 Jan 2016 10:03:28 +0100 [thread overview]
Message-ID: <568B86E0.6000400@st.com> (raw)
In-Reply-To: <20160104.222549.839329360046336198.davem@davemloft.net>
On 1/5/2016 4:25 AM, David Miller wrote:
> From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Date: Mon, 4 Jan 2016 14:06:46 +0100
>
>> @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops;
>> /* Specific DMA helpers */
>> struct stmmac_dma_ops {
>> /* DMA core initialization */
>> - int (*init) (void __iomem *ioaddr, int pbl, int fb, int mb,
>> + int (*reset)(void __iomem *ioaddr);
>> + void (*init)(void __iomem *ioaddr, int pbl, int fb, int mb,
>> int burst_len, u32 dma_tx, u32 dma_rx, int atds);
>
> Since you change the return type of the 'init' method, and this
> changes the column of the openning parenthesis, you have to fix the
> indentation of the argument list on the next line.
>
hmm, lines are well aligned.
I will check again, in case of I introduced some indentation problem.
peppe
next prev parent reply other threads:[~2016-01-05 9:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 13:06 [PATCHv2 (net-next.git) 00/18] stmmac: enhance driver performances and update the version Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000 Giuseppe Cavallaro
2016-01-05 3:25 ` David Miller
2016-01-05 9:03 ` Giuseppe CAVALLARO [this message]
2016-01-05 18:45 ` David Miller
2016-02-01 15:54 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure Giuseppe Cavallaro
2016-01-05 3:29 ` David Miller
2016-01-05 9:32 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 03/18] stmmac: change descriptor layout Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 04/18] stmmac: remove modulo in stmmac_xmit() Giuseppe Cavallaro
2016-01-05 3:34 ` David Miller
2016-01-05 8:56 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 05/18] stmmac: add length field to dma data Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 06/18] stmmac: add last_segment " Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 07/18] stmmac: add is_jumbo " Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 08/18] stmmac: merge get_rx_owner into rx_status routine Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management Giuseppe Cavallaro
2016-01-05 3:39 ` David Miller
2016-01-05 8:57 ` Giuseppe CAVALLARO
2016-01-04 13:06 ` [PATCH (net-next.git) 10/18] stmmac: optimize tx clean function Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 11/18] stmmac: set dirty index out of the loop Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 12/18] stmmac: first frame prep at the end of xmit routine Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 13/18] stmmac: perf, remove modulo in stmmac_rx() Giuseppe Cavallaro
2016-01-04 13:06 ` [PATCH (net-next.git) 14/18] stmmac: do not poll phy handler when attach a switch Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCH (net-next.git) 15/18] stmmac: fix phy init when attached to a phy Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCHv2 (net-next.git) 16/18] stmmac: do not perform zero-copy for rx frames Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCH (net-next.git) 17/18] stmmac: tune rx copy via threshold Giuseppe Cavallaro
2016-01-04 13:07 ` [PATCH (net-next.git) 18/18] stmmac: update version to Oct_2015 Giuseppe Cavallaro
-- strict thread matches above, loose matches on Subject: below --
2015-12-09 8:37 [PATCH (net-next.git) 00/18] stmmac: enhance driver performances and update the version Giuseppe Cavallaro
2015-12-09 8:37 ` [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000 Giuseppe Cavallaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B86E0.6000400@st.com \
--to=peppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.