From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 05 Jan 2016 09:06:58 +0000 Subject: Re: [patch] drm/amd/powerplay: fix a reversed condition Message-Id: <568B87B2.5010105@users.sourceforge.net> List-Id: References: <20160104204255.GB19867@mwanda> In-Reply-To: <20160104204255.GB19867@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Jammy Zhou , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Alex Deucher , Rex Zhu > This test was reversed so it would end up leading to a NULL dereference. > > Fixes: 4630f0faae80 ('drm/amd/powerplay: add Carrizo smu support') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > index e74023b..873a8d2 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > @@ -818,7 +818,7 @@ static int cz_smu_fini(struct pp_smumgr *smumgr) > return -EINVAL; > > cz_smu = (struct cz_smumgr *)smumgr->backend; > - if (!cz_smu) { > + if (cz_smu) { > cgs_free_gpu_mem(smumgr->device, > cz_smu->toc_buffer.handle); > cgs_free_gpu_mem(smumgr->device, Was this issue found by an automatic static source code analysis of a tool like "Smatch"? https://blogs.oracle.com/linuxkernel/entry/smatch_static_analysis_tool_overview http://smatch.sourceforge.net/ Would it be useful to detect similar update candidates by the reuse of scripts for the semantic patch language? How do you think about to get additional help and support from a software like Coccinelle for such search patterns? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [patch] drm/amd/powerplay: fix a reversed condition Date: Tue, 5 Jan 2016 10:06:58 +0100 Message-ID: <568B87B2.5010105@users.sourceforge.net> References: <20160104204255.GB19867@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.web.de (mout.web.de [212.227.17.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07F6C6E538 for ; Tue, 5 Jan 2016 01:07:13 -0800 (PST) In-Reply-To: <20160104204255.GB19867@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: Jammy Zhou , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Alex Deucher , Rex Zhu List-Id: dri-devel@lists.freedesktop.org PiBUaGlzIHRlc3Qgd2FzIHJldmVyc2VkIHNvIGl0IHdvdWxkIGVuZCB1cCBsZWFkaW5nIHRvIGEg TlVMTCBkZXJlZmVyZW5jZS4KPiAKPiBGaXhlczogNDYzMGYwZmFhZTgwICgnZHJtL2FtZC9wb3dl cnBsYXk6IGFkZCBDYXJyaXpvIHNtdSBzdXBwb3J0JykKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2Fy cGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdW1nci9jel9zbXVtZ3IuYyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvcG93ZXJwbGF5L3NtdW1nci9jel9zbXVtZ3IuYwo+IGluZGV4IGU3NDAyM2IuLjg3 M2E4ZDIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvc211bWdy L2N6X3NtdW1nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvc211bWdy L2N6X3NtdW1nci5jCj4gQEAgLTgxOCw3ICs4MTgsNyBAQCBzdGF0aWMgaW50IGN6X3NtdV9maW5p KHN0cnVjdCBwcF9zbXVtZ3IgKnNtdW1ncikKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gIAlj el9zbXUgPSAoc3RydWN0IGN6X3NtdW1nciAqKXNtdW1nci0+YmFja2VuZDsKPiAtCWlmICghY3pf c211KSB7Cj4gKwlpZiAoY3pfc211KSB7Cj4gIAkJY2dzX2ZyZWVfZ3B1X21lbShzbXVtZ3ItPmRl dmljZSwKPiAgCQkJCWN6X3NtdS0+dG9jX2J1ZmZlci5oYW5kbGUpOwo+ICAJCWNnc19mcmVlX2dw dV9tZW0oc211bWdyLT5kZXZpY2UsCgpXYXMgdGhpcyBpc3N1ZSBmb3VuZCBieSBhbiBhdXRvbWF0 aWMgc3RhdGljIHNvdXJjZSBjb2RlIGFuYWx5c2lzIG9mIGEgdG9vbApsaWtlICJTbWF0Y2giPwpo dHRwczovL2Jsb2dzLm9yYWNsZS5jb20vbGludXhrZXJuZWwvZW50cnkvc21hdGNoX3N0YXRpY19h bmFseXNpc190b29sX292ZXJ2aWV3Cmh0dHA6Ly9zbWF0Y2guc291cmNlZm9yZ2UubmV0LwoKCldv dWxkIGl0IGJlIHVzZWZ1bCB0byBkZXRlY3Qgc2ltaWxhciB1cGRhdGUgY2FuZGlkYXRlcyBieSB0 aGUgcmV1c2Ugb2Ygc2NyaXB0cwpmb3IgdGhlIHNlbWFudGljIHBhdGNoIGxhbmd1YWdlPwpIb3cg ZG8geW91IHRoaW5rIGFib3V0IHRvIGdldCBhZGRpdGlvbmFsIGhlbHAgYW5kIHN1cHBvcnQgZnJv bSBhIHNvZnR3YXJlCmxpa2UgQ29jY2luZWxsZSBmb3Igc3VjaCBzZWFyY2ggcGF0dGVybnM/CgpS ZWdhcmRzLApNYXJrdXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK