From: Tomas Henzl <thenzl@redhat.com>
To: Colin King <colin.king@canonical.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: mvsas: fix indenting on return error code
Date: Tue, 5 Jan 2016 13:35:36 +0100 [thread overview]
Message-ID: <568BB898.8040403@redhat.com> (raw)
In-Reply-To: <1451995000-9210-1-git-send-email-colin.king@canonical.com>
On 5.1.2016 12:56, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The return code and error return is incorrectly indented which
> may cause some confusion as it appears at first sight to be associated
> with a device not ready error (with missing { } braces) rather than
> a DEV_IS_GONE() failure.
>
> The incorrect indenting was introduced by commit
> 0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
> for Task collector mode and fixed relative bugs")
>
> No functional change, just a minor code reformatting clean up.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
next prev parent reply other threads:[~2016-01-05 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 11:56 [PATCH] scsi: mvsas: fix indenting on return error code Colin King
2016-01-05 12:35 ` Tomas Henzl [this message]
2016-01-06 20:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568BB898.8040403@redhat.com \
--to=thenzl@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=colin.king@canonical.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.