From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbcAEQXi (ORCPT ); Tue, 5 Jan 2016 11:23:38 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:35888 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbcAEQXe (ORCPT ); Tue, 5 Jan 2016 11:23:34 -0500 Subject: Re: [PATCH] Add possibility to set /dev/tty number To: "Theodore Ts'o" , G@thunk.org, One Thousand Gnomes , Greg KH , Pierre Paul MINGOT , jslaby@suse.cz, linux-kernel@vger.kernel.org References: <20160104154305.GA24533@kroah.com> <568AA47D.6010604@gmail.com> <20160104171121.GA25961@kroah.com> <568ABCBD.3070909@gmail.com> <20160104225544.158dc847@lxorguk.ukuu.org.uk> <568BC244.5040207@gmail.com> <20160105161145.GA7138@thunk.org> From: "Austin S. Hemmelgarn" Message-ID: <568BEDBA.1090006@gmail.com> Date: Tue, 5 Jan 2016 11:22:18 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160105161145.GA7138@thunk.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 160105-0, 2016-01-05), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-01-05 11:11, Theodore Ts'o wrote: > On Tue, Jan 05, 2016 at 08:16:52AM -0500, Austin S. Hemmelgarn wrote: >>> We don't do regressions. >> Requiring only a recompilation isn't a regression, especially when it works >> fine without being recompiled, and I have yet to actually see anything that >> changing the number of VT's would break other than ConsoleKit >> (systemd-logind might also need a rebuild, but I'm not sure about that, and >> don't have a system I could test it on). > > Sorry, breaking a compiled binary is a regression. > > People have outlined more clever ways of trying to accomplish your > goal (saving memory) without breaking other people. I suggest you > give that a try instead of just trying to defend your existing patch. > First, it's not my patch. Second, my usage of the term 'break' was probably not the best choice here, as ConsoleKit doesn't stop working. All that happens is that it spits out some warnings about not finding VT's that it thinks should be there. All that recompiling gets you is that it stops it from spitting out these warnings, which could just as easily be suppressed by other means. And, while I can't personally test this, I'm pretty certain that the same applies to systemd-logind. They have to gracefully cope with not being able to see all the VT's they think they should, because it's fully possible for something to hook into early boot and deallocate most of them before ConsoleKit or logind run. Third, as Greg stated in his response to the patch, it should be updated so that the default matches current behavior, which would mean that nothing would break unless the person building the kernel chose to break it.