All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] dm: add dev_get_reg() for getting device node's reg
Date: Tue, 5 Jan 2016 10:05:12 -0700	[thread overview]
Message-ID: <568BF7C8.6040706@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ37ORhL2KqAf=nir5iy_njUaV7Nbes-0+YbmtYxaPt0CQ@mail.gmail.com>

On 01/04/2016 05:58 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 4 January 2016 at 13:02, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> On 12/29/2015 01:47 AM, Przemyslaw Marczak wrote:
>>>
>>> Hello Stephen,
>>>
>>> On 12/16/2015 07:53 PM, Stephen Warren wrote:
>>>>
>>>> On 12/15/2015 09:32 AM, Przemyslaw Marczak wrote:
>>>>>
>>>>> commit: dm: core: Enable optional use of fdt_translate_address()
>>>>>
>>>>> enables device's bus/child address translation method, depending
>>>>> on bus 'ranges' property and including child 'reg' property.
>>>>> This change makes impossible to decode the 'reg' for node with
>>>>> '#size-cells' equal to 0.
>>>>>
>>>>> Such case is possible by the specification and is also used in U-Boot,
>>>>> e.g. by I2C uclass or S5P GPIO - the last one is broken at present.
>>>>
>>>>
>>>> Can you please explain the problem you're seeing in more detail? Without
>>>> any context, my initial reaction is that this is simply a bug somewhere.
>>>> That bug should be fixed, rather than introducing new APIs to hide the
>>>> problem.
>>>>
>>>
>>> Some time ago I send a patch with such fix:
>>>
>>> [1] https://patchwork.ozlabs.org/patch/537372/
>>>
>>> Sorry, I didn't add you to the 'CC' list.
>>>
>>> However. I checked this in linux, and the code is the same, the
>>> size-cells == 0 is not supported also in Linux.
>>
>>
>> The discussion there does indicate that removing the check on #size-cells would be incorrect.
>
> OK, but since we have a breakage and a release in a week, I'm planning
> on picking up Przemyslaw's patch. We can revert it immediately
> afterwards.
>
> Who is going to work out a proper solution (post-release)?

I would assume the owner of the affected I2C/SPI controllers, or if the 
issue is triggered by core/subsystem code, then the owner of that subsystem.

  reply	other threads:[~2016-01-05 17:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 16:32 [U-Boot] [PATCH 0/3] dm: add dev_get_reg() for getting device node's reg Przemyslaw Marczak
2015-12-15 16:32 ` [U-Boot] [PATCH 1/3] dm: core: extend API by new function: dev_get_reg() Przemyslaw Marczak
2015-12-15 16:32 ` [U-Boot] [PATCH 2/3] gpio: s5p: use dev_get_reg() instead of dev_get_addr() Przemyslaw Marczak
2015-12-15 16:32 ` [U-Boot] [PATCH 3/3] dm: i2c: get chip address with dev_get_reg() Przemyslaw Marczak
2015-12-16 18:53 ` [U-Boot] [PATCH 0/3] dm: add dev_get_reg() for getting device node's reg Stephen Warren
2015-12-16 19:07   ` Stephen Warren
2015-12-29  8:47     ` Przemyslaw Marczak
2016-01-04 20:06       ` Stephen Warren
2016-01-05 15:38         ` Przemyslaw Marczak
2016-01-05 17:12           ` Stephen Warren
2016-01-06  0:24             ` Simon Glass
2016-01-06 19:14               ` Stephen Warren
2016-01-07 11:57               ` Przemyslaw Marczak
2015-12-29  8:47   ` Przemyslaw Marczak
2016-01-04 20:02     ` Stephen Warren
2016-01-05  0:58       ` Simon Glass
2016-01-05 17:05         ` Stephen Warren [this message]
2016-01-05 15:37       ` Przemyslaw Marczak
2016-01-05 17:08         ` Stephen Warren
2016-01-07 11:45           ` Przemyslaw Marczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568BF7C8.6040706@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.