From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752636AbcAFBsq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 20:48:46 -0500
Received: from mga11.intel.com ([192.55.52.93]:44902 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752510AbcAFBso (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 20:48:44 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,527,1444719600"; 
   d="scan'208";a="24271634"
Message-ID: <568C727A.9050904@linux.intel.com>
Date: Wed, 06 Jan 2016 09:48:42 +0800
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
CC: "Qiu, PeiyangX" <peiyangx.qiu@intel.com>, Ingo Molnar <mingo@redhat.com>,
        Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] module: deal with the failure of complete_formation
References: <567CE0A7.80605@intel.com>	<567CEA31.1070507@intel.com>	<20160105200114.59fbf832@gandalf.local.home>	<568C6A82.6090202@linux.intel.com> <20160105202948.209acfb5@gandalf.local.home>
In-Reply-To: <20160105202948.209acfb5@gandalf.local.home>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/1/6 9:29, Steven Rostedt wrote:
> On Wed, 06 Jan 2016 09:14:42 +0800
> "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> wrote:
>
>
>> It's a good idea although ftrace_module_init_fail might be complicated.
> How so? I posted the patch. All it does is to call
> ftrace_release_mod(), which will only remove pages that are included
> with the module. If the pages were not added yet, nothing is done.

You are right. ftrace_release_mod can be used.