From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] arm: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE
Date: Wed, 6 Jan 2016 09:57:12 +0800 [thread overview]
Message-ID: <568C7478.6060305@wytron.com.tw> (raw)
In-Reply-To: <CAPnjgZ0PDP8eA7CZ=QWpJmV8E9o2fMMH2yKhAPbfw=p-_BdSLw@mail.gmail.com>
Hi Simon,
On 2016?01?06? 08:24, Simon Glass wrote:
> +Masahiro
>
> Hi Thomas,
>
> On 5 January 2016 at 06:16, Thomas Chou <thomas@wytron.com.tw> wrote:
>> Hi Simon,
>>
>> On 2016?01?05? 08:56, Simon Glass wrote:
>>>
>>> One of the benefits of device tree is that we can run the same code
>>> paths on multiple boards. Then buildman has less work to do. For
>>> example, if it builds 'snow' then we know that 'pit' and 'pi' are good
>>> also. If you change the way device trees work then we lose this
>>> benefit. It would be great if we could build (say) 100 boards for 100%
>>> code coverage instead of 1000 boards.
>>>
>>> If you can find a way to build all the device tree files for a
>>> particular SoC without listing them out in the Makefile, then fine.
>>> But I really don't want to lose that feature. It is very useful.
>>>
>>
>> I am preparing an update v2 to support building list of DT from configs.
>>
>> By adding support of list to DEFAULT_DEVICE_TREE,
>> This option specifies a space-separated list of Device Tree used
>> for DT control. Each DT in the list will be compiled. The first will be
>> used as default to ship.
>
> It would be better if we could ship all of them, and select the right
> tone at run-time.
>
>>
>>> Another example is sandbox, which builds both 'sandbox.dts' and
>>> 'test.dts'. It allows us to run a test easily:
>>>
>>> ./sandbox/u-boot -d sandbox/arch/sandbox/dts/test.dtb -c "ut dm
>>> usb_kdb" for example.
>>>
>>> If we didn't have that it would be a right pain to run tests.
>>>
>>
>> No problem. The test.dtb rules is retained.
>>
>>> I still don't understand what problem you are trying to solve. Can you
>>> explain again what is wrong with the status quo?
>>
>>
>> The current build generate too many DTB that users probably don't want/need.
>> And the arch//dts/Makefile grows fat as every new board/target add lines to
>> it. There should be some way to handle it in a cleaner style.
>
> But at least we get a clear list of what is includes, and what SoC it
> relates to. Linux uses the same approach. I'm really not sold on this
> idea.
>
Thanks for the explanation. Now I understand. But there is no harm to
add list support for building DT to configs. Please review and pick 1/9
and 2/9 of PATCH v2. And leave the rest to arch custodians.
Best regards,
Thomas
next prev parent reply other threads:[~2016-01-06 1:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 13:44 [U-Boot] [PATCH 1/7] devicetree: use wildcard to clean arch subdir Thomas Chou
2015-12-27 13:44 ` [U-Boot] [PATCH 2/7] arc: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE Thomas Chou
2015-12-28 2:16 ` Bin Meng
2016-01-11 11:06 ` Alexey Brodkin
2015-12-27 13:44 ` [U-Boot] [PATCH 3/7] arm: " Thomas Chou
2015-12-28 2:16 ` Bin Meng
2015-12-29 0:22 ` Simon Glass
2015-12-29 0:55 ` Thomas Chou
2016-01-05 0:56 ` Simon Glass
2016-01-05 13:16 ` Thomas Chou
2016-01-06 0:24 ` Simon Glass
2016-01-06 1:57 ` Thomas Chou [this message]
2016-01-06 2:22 ` Masahiro Yamada
2016-01-06 2:38 ` Thomas Chou
2015-12-27 13:44 ` [U-Boot] [PATCH 4/7] microblaze: " Thomas Chou
2015-12-28 2:16 ` Bin Meng
2016-01-04 9:15 ` Michal Simek
2015-12-27 13:44 ` [U-Boot] [PATCH 5/7] powerpc: " Thomas Chou
2015-12-28 2:16 ` Bin Meng
2015-12-27 13:44 ` [U-Boot] [PATCH 6/7] sandbox: " Thomas Chou
2015-12-28 2:16 ` Bin Meng
2015-12-27 13:44 ` [U-Boot] [PATCH 7/7] x86: " Thomas Chou
2015-12-28 2:16 ` Bin Meng
2015-12-28 2:16 ` [U-Boot] [PATCH 1/7] devicetree: use wildcard to clean arch subdir Bin Meng
2016-01-06 1:49 ` [U-Boot] [PATCH v2 1/9] " Thomas Chou
2016-01-06 1:49 ` [U-Boot] [PATCH v2 2/9] devicetree: support list of Device Tree in DEFAULT_DEVICE_TREE Thomas Chou
2016-01-08 3:34 ` Simon Glass
2016-01-06 1:49 ` [U-Boot] [PATCH v2 3/9] nios2: " Thomas Chou
2016-01-06 1:49 ` [U-Boot] [PATCH v2 4/9] arc: use generic dtb rule with CONFIG_DEFAULT_DEVICE_TREE Thomas Chou
2016-01-06 1:49 ` [U-Boot] [PATCH v2 5/9] arm: " Thomas Chou
2016-01-06 1:49 ` [U-Boot] [PATCH v2 6/9] microblaze: " Thomas Chou
2016-01-06 7:46 ` Michal Simek
2016-01-06 1:49 ` [U-Boot] [PATCH v2 7/9] powerpc: " Thomas Chou
2016-01-06 1:49 ` [U-Boot] [PATCH v2 8/9] sandbox: " Thomas Chou
2016-01-06 1:49 ` [U-Boot] [PATCH v2 9/9] x86: " Thomas Chou
2016-01-13 20:10 ` [U-Boot] [PATCH v2 1/9] devicetree: use wildcard to clean arch subdir Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568C7478.6060305@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.