Re: [PATCH] Btrfs: fix output of compression message in btrfs_parse_options()

[Tsutomu Itoh <t-itoh@jp.fujitsu.com>]

Hi, David,

On 2016/01/05 23:12, David Sterba wrote:
> On Wed, Dec 16, 2015 at 11:57:38AM +0900, Tsutomu Itoh wrote:
>> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
>> index 974be09..dcc1f15 100644
>> --- a/fs/btrfs/disk-io.c
>> +++ b/fs/btrfs/disk-io.c
>> @@ -2709,7 +2709,7 @@ int open_ctree(struct super_block *sb,
>>   	 * In the long term, we'll store the compression type in the super
>>   	 * block, and it'll be used for per file compression control.
>>   	 */
>> -	fs_info->compress_type = BTRFS_COMPRESS_ZLIB;
>> +	fs_info->compress_type = BTRFS_COMPRESS_NONE;
>
> This would change the default compression type, eg. when the compression
> is turned on via chattr +c . This would break the applications out
> there, the fix has to avoid changing that.

Thanks for pointing that out. I had forgotten chattr +c.
I'll post V2 patch later.

Thanks,
Tsutomu