From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI Date: Wed, 6 Jan 2016 12:16:52 +0800 Message-ID: <568C9534.3050700@rock-chips.com> References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> <568C7258.3010104@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <568C7258.3010104-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Mark yao , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org Cc: airlied-cv59FeDIM0c@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgTWFyawoKCk9uIDAxLzA2LzIwMTYgMDk6NDggQU0sIE1hcmsgeWFvIHdyb3RlOgo+IE9uIDIw MTXlubQxMuaciDIz5pelIDExOjQzLCBDaHJpcyBaaG9uZyB3cm90ZToKPj4gK3N0YXRpYyBpbnQg ZHdfbWlwaV9kc2lfcmVnaXN0ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRybSwKPj4gKyAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSkKPj4gK3sKPj4gKyAgICBzdHJ1 Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIgPSAmZHNpLT5lbmNvZGVyOwo+PiArICAgIHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IgPSAmZHNpLT5jb25uZWN0b3I7Cj4+ICsgICAgc3RydWN0 IGRldmljZSAqZGV2ID0gZHNpLT5kZXY7Cj4+ICsgICAgaW50IHJldDsKPj4gKwo+PiArICAgIGVu Y29kZXItPnBvc3NpYmxlX2NydGNzID0gZHJtX29mX2ZpbmRfcG9zc2libGVfY3J0Y3MoZHJtLAo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2LT5vZl9ub2RlKTsKPj4gKyAg ICAvKgo+PiArICAgICAqIElmIHdlIGZhaWxlZCB0byBmaW5kIHRoZSBDUlRDKHMpIHdoaWNoIHRo aXMgZW5jb2RlciBpcwo+PiArICAgICAqIHN1cHBvc2VkIHRvIGJlIGNvbm5lY3RlZCB0bywgaXQn cyBiZWNhdXNlIHRoZSBDUlRDIGhhcwo+PiArICAgICAqIG5vdCBiZWVuIHJlZ2lzdGVyZWQgeWV0 LiAgRGVmZXIgcHJvYmluZywgYW5kIGhvcGUgdGhhdAo+PiArICAgICAqIHRoZSByZXF1aXJlZCBD UlRDIGlzIGFkZGVkIGxhdGVyLgo+PiArICAgICAqLwo+PiArICAgIGlmIChlbmNvZGVyLT5wb3Nz aWJsZV9jcnRjcyA9PSAwKQo+PiArICAgICAgICByZXR1cm4gLUVQUk9CRV9ERUZFUjsKPj4gKwo+ PiArICAgIGRybV9lbmNvZGVyX2hlbHBlcl9hZGQoJmRzaS0+ZW5jb2RlciwKPj4gKyAgICAgICAg ICAgICAgICAgICAmZHdfbWlwaV9kc2lfZW5jb2Rlcl9oZWxwZXJfZnVuY3MpOwo+PiArICAgIHJl dCA9IGRybV9lbmNvZGVyX2luaXQoZHJtLCAmZHNpLT5lbmNvZGVyLCAKPj4gJmR3X21pcGlfZHNp X2VuY29kZXJfZnVuY3MsCj4+ICsgICAgICAgICAgICAgRFJNX01PREVfRU5DT0RFUl9EU0kpOwo+ PiArICAgIGlmIChyZXQpIHsKPj4gKyAgICAgICAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gaW5p dGlhbGl6ZSBlbmNvZGVyIHdpdGggZHJtXG4iKTsKPj4gKyAgICAgICAgcmV0dXJuIHJldDsKPj4g KyAgICB9Cj4+ICsKPj4gKyAgICBkcm1fY29ubmVjdG9yX2hlbHBlcl9hZGQoY29ubmVjdG9yLAo+ PiArICAgICAgICAgICAgJmR3X21pcGlfZHNpX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MpOwo+PiAr Cj4+ICsgICAgZHJtX2Nvbm5lY3Rvcl9pbml0KGRybSwgJmRzaS0+Y29ubmVjdG9yLAo+PiArICAg ICAgICAgICAgICAgJmR3X21pcGlfZHNpX2F0b21pY19jb25uZWN0b3JfZnVuY3MsCj4+ICsgICAg ICAgICAgICAgICBEUk1fTU9ERV9DT05ORUNUT1JfRFNJKTsKPj4gKwo+IEhpIENocmlzCj4KPiBJ IHRyeSB0byBwaWNrIHlvdXIgcGF0Y2hlcywgYnV0IGZvdW5kIGZvbGxvd2luZyBpc3N1ZXM6Cj4K PiBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYzog5Zyo5Ye95pWw4oCYZHdf bWlwaV9kc2lfcmVnaXN0ZXLigJnkuK06Cj4gZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1p cGktZHNpLmM6MTAyNDo1OiDplJnor6/vvJog5o+Q5L6b57uZ5Ye95pWwIAo+IOKAmGRybV9lbmNv ZGVyX2luaXTigJnnmoTlrp7lj4LlpKrlsJEKPiBpbmNsdWRlL2RybS9kcm1fY3J0Yy5oOjIyMjA6 NTog6ZmE5rOo77yaIOWcqOatpOWjsOaYjgo+IG1ha2VbNF06ICoqKiBbZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL2R3LW1pcGktZHNpLm9dIOmUmeivryAxCj4KPiBDYW4geW91IHJlYmFzZSB0byBu ZXdlc3QgRGF2ZSdzIGRybS1uZXh0IGFuZCBmaXggdGhpcyBwcm9ibGVtPwpUaGFua3MgTWFyay4K SSBoYXZlIHBvc3QgdGhlIHY3IHNlcmlhbCwgZml4IHRoaXMgdGhpcyBjb21waWxlIGVyciBhbmQg bW9kaWZ5IHRoZSAKY29uZmlnIHRvIHRyaXN0YXRlIGZvciBtb2R1bGVzIGJ1aWxkCj4KPiBUaGFu a3MuCj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJv Y2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Wed, 6 Jan 2016 12:16:52 +0800 Subject: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI In-Reply-To: <568C7258.3010104@rock-chips.com> References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> <568C7258.3010104@rock-chips.com> Message-ID: <568C9534.3050700@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark On 01/06/2016 09:48 AM, Mark yao wrote: > On 2015?12?23? 11:43, Chris Zhong wrote: >> +static int dw_mipi_dsi_register(struct drm_device *drm, >> + struct dw_mipi_dsi *dsi) >> +{ >> + struct drm_encoder *encoder = &dsi->encoder; >> + struct drm_connector *connector = &dsi->connector; >> + struct device *dev = dsi->dev; >> + int ret; >> + >> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, >> + dev->of_node); >> + /* >> + * If we failed to find the CRTC(s) which this encoder is >> + * supposed to be connected to, it's because the CRTC has >> + * not been registered yet. Defer probing, and hope that >> + * the required CRTC is added later. >> + */ >> + if (encoder->possible_crtcs == 0) >> + return -EPROBE_DEFER; >> + >> + drm_encoder_helper_add(&dsi->encoder, >> + &dw_mipi_dsi_encoder_helper_funcs); >> + ret = drm_encoder_init(drm, &dsi->encoder, >> &dw_mipi_dsi_encoder_funcs, >> + DRM_MODE_ENCODER_DSI); >> + if (ret) { >> + dev_err(dev, "Failed to initialize encoder with drm\n"); >> + return ret; >> + } >> + >> + drm_connector_helper_add(connector, >> + &dw_mipi_dsi_connector_helper_funcs); >> + >> + drm_connector_init(drm, &dsi->connector, >> + &dw_mipi_dsi_atomic_connector_funcs, >> + DRM_MODE_CONNECTOR_DSI); >> + > Hi Chris > > I try to pick your patches, but found following issues: > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c: ????dw_mipi_dsi_register??: > drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: ??? ????? > ?drm_encoder_init?????? > include/drm/drm_crtc.h:2220:5: ??? ???? > make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] ?? 1 > > Can you rebase to newest Dave's drm-next and fix this problem? Thanks Mark. I have post the v7 serial, fix this this compile err and modify the config to tristate for modules build > > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbcAFKBS (ORCPT ); Wed, 6 Jan 2016 05:01:18 -0500 Received: from sg-smtp01.263.net ([54.255.195.220]:34453 "EHLO sg-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcAFKBM (ORCPT ); Wed, 6 Jan 2016 05:01:12 -0500 X-Greylist: delayed 20644 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Jan 2016 05:01:12 EST X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI To: Mark yao , heiko@sntech.de, linux-rockchip@lists.infradead.org, treding@nvidia.com References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> <568C7258.3010104@rock-chips.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-arm-kernel@lists.infradead.org From: Chris Zhong Message-ID: <568C9534.3050700@rock-chips.com> Date: Wed, 6 Jan 2016 12:16:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <568C7258.3010104@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark On 01/06/2016 09:48 AM, Mark yao wrote: > On 2015年12月23日 11:43, Chris Zhong wrote: >> +static int dw_mipi_dsi_register(struct drm_device *drm, >> + struct dw_mipi_dsi *dsi) >> +{ >> + struct drm_encoder *encoder = &dsi->encoder; >> + struct drm_connector *connector = &dsi->connector; >> + struct device *dev = dsi->dev; >> + int ret; >> + >> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, >> + dev->of_node); >> + /* >> + * If we failed to find the CRTC(s) which this encoder is >> + * supposed to be connected to, it's because the CRTC has >> + * not been registered yet. Defer probing, and hope that >> + * the required CRTC is added later. >> + */ >> + if (encoder->possible_crtcs == 0) >> + return -EPROBE_DEFER; >> + >> + drm_encoder_helper_add(&dsi->encoder, >> + &dw_mipi_dsi_encoder_helper_funcs); >> + ret = drm_encoder_init(drm, &dsi->encoder, >> &dw_mipi_dsi_encoder_funcs, >> + DRM_MODE_ENCODER_DSI); >> + if (ret) { >> + dev_err(dev, "Failed to initialize encoder with drm\n"); >> + return ret; >> + } >> + >> + drm_connector_helper_add(connector, >> + &dw_mipi_dsi_connector_helper_funcs); >> + >> + drm_connector_init(drm, &dsi->connector, >> + &dw_mipi_dsi_atomic_connector_funcs, >> + DRM_MODE_CONNECTOR_DSI); >> + > Hi Chris > > I try to pick your patches, but found following issues: > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c: 在函数‘dw_mipi_dsi_register’中: > drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: 错误： 提供给函数 > ‘drm_encoder_init’的实参太少 > include/drm/drm_crtc.h:2220:5: 附注： 在此声明 > make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] 错误 1 > > Can you rebase to newest Dave's drm-next and fix this problem? Thanks Mark. I have post the v7 serial, fix this this compile err and modify the config to tristate for modules build > > Thanks. >