Re: [PATCH] net: take care of bonding in build_skb_flow_key

[Wengang Wang <wen.gang.wang@oracle.com>]

在 2016年01月06日 14:18, David Miller 写道:
> From: Wengang Wang <wen.gang.wang@oracle.com>
> Date: Wed,  6 Jan 2016 13:49:28 +0800
>
>> @@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4, const struct sk_buff *skb,
>>   			       const struct sock *sk)
>>   {
>>   	const struct iphdr *iph = ip_hdr(skb);
>> -	int oif = skb->dev->ifindex;
>> +	int oif;
>> +	struct net_device *master = NULL;
>> +
>>   	u8 tos = RT_TOS(iph->tos);
>>   	u8 prot = iph->protocol;
>>   	u32 mark = skb->mark;
>>   
> Please fix the stlye of these variable declarations:
>
> 1) Order them from longest line to shortest line, also known
>     as "reverse christmas tree" layout.
>
> 2) Do not add an empty line in the middle of these variable
>     declarations.
OK, will do in second drop.

thanks,
wengang