From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGsL8-0003te-Ae for qemu-devel@nongnu.org; Wed, 06 Jan 2016 12:57:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGsL7-0000zN-HX for qemu-devel@nongnu.org; Wed, 06 Jan 2016 12:57:42 -0500 References: <1451983580-10561-1-git-send-email-famz@redhat.com> <1451983580-10561-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <568D5589.9070208@redhat.com> Date: Wed, 6 Jan 2016 18:57:29 +0100 MIME-Version: 1.0 In-Reply-To: <1451983580-10561-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CRoMmhlab1PVmtRSbd4BpFxoIBODpatOE" Subject: Re: [Qemu-devel] [PATCH v9 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CRoMmhlab1PVmtRSbd4BpFxoIBODpatOE Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.01.2016 09:46, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >=20 > Rewrite mirror_iteration to fix both flaws. >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 347 +++++++++++++++++++++++++++++++++++--------------= -------- > trace-events | 1 - > 2 files changed, 216 insertions(+), 132 deletions(-) Side note: This breaks the output of iotest 109, probably due to different alignment of the mirroring operations (doesn't look serious, though). Max --CRoMmhlab1PVmtRSbd4BpFxoIBODpatOE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWjVWJAAoJEDuxQgLoOKytTAUH/1uUfOK45Ilw/KmQlss15HcL Z5qr0dK8m2tjd/X+iy524Tnh62ZlwWbcFOIJCGT+stkwxxvk7ZKfgJaqeDsUutx5 2WatQLj3ThT4eGBM9qrtzHvD4RntBva9kTvCzT8N9AIAQr5gPdZ/80n7u+15G/Fh w8bzmmGKyYuZaPMkoMnNWObxP4sYA1YlLHhuQoZlb5D5HT8pKFyF0RuLPDDAOfit ypzOiLk92mXUA7OgAgrLWTyB0/UNvJeTRrR9cCUiNTnGMQoTr0RmhvmkCKW91ubM dI8DCHurb0x4p9dfUqdEGnAS05jzS6Rc++lBECCPk4rSk7wNhyEXiq0mw5CUV14= =XFFC -----END PGP SIGNATURE----- --CRoMmhlab1PVmtRSbd4BpFxoIBODpatOE--