All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/6] package/mesa3d: reorder select/depends
Date: Wed, 6 Jan 2016 22:00:32 +0100	[thread overview]
Message-ID: <568D8070.90501@gmail.com> (raw)
In-Reply-To: <87egdxhqv5.fsf@dell.be.48ers.dk>

Hi Peter,

Le 05/01/2016 00:22, Peter Korsgaard a ?crit :
>>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> 
>  >> From [1]:
>  > "Even though the ordering has absolutely no consequences in Kconfig, it
>  > is not logical (when reading). It is more logical and far easier to
>  > understand when depends come first, followed by the selects."
> 
>  > Also, the Config.in exemple in the manual suggest to use this coding
>  > style [2].
> 
>  > [1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
>  > [2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in
> 
>  > Signed-off-by: Romain Naour <romain.naour@gmail.com>
> 
> Committed patch 1-5, thanks. I had already applied a similar patch from
> Gustavoz for xapp_xbacklight. That one didn't select libxcb though, but
> I guess it doesn't really matter as libX11 pulls it in.

No problem, I'll remove patch 6 from the patchwork.

> 
> (xcb-util should arguably select libxcb as it is a library instead of
> using depends on).
> 

Yes probably. Using "depends on" would help if libxcb would have several
dependencies (like for the efl package) but there is none.

Best regards,
Romain

      reply	other threads:[~2016-01-06 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04  0:11 [Buildroot] [PATCH 1/6] package/mesa3d: reorder select/depends Romain Naour
2016-01-04  0:11 ` [Buildroot] [PATCH 2/6] package/mesa3d: select packages required by dri3proto support dependencies Romain Naour
2016-01-04  0:11 ` [Buildroot] [PATCH 3/6] package/x11r7/xserver_xorg-server: reorder select/depends Romain Naour
2016-01-04  0:11 ` [Buildroot] [PATCH 4/6] package/x11r7/xserver_xorg-server: select xlib_libxshmfence required by dri3proto support dependencies Romain Naour
2016-01-04  0:11 ` [Buildroot] [PATCH 5/6] package/x11r7/xserver_xorg-server: move libpciaccess selection Romain Naour
2016-01-04  0:11 ` [Buildroot] [PATCH 6/6] package/x11r7/xapp_xbacklight: select xcb-util package Romain Naour
2016-01-04 23:22 ` [Buildroot] [PATCH 1/6] package/mesa3d: reorder select/depends Peter Korsgaard
2016-01-06 21:00   ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568D8070.90501@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.