From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH1AV-0001Io-Ru for qemu-devel@nongnu.org; Wed, 06 Jan 2016 22:23:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aH1AQ-0007le-Ry for qemu-devel@nongnu.org; Wed, 06 Jan 2016 22:23:19 -0500 Received: from [59.151.112.132] (port=24292 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH1AQ-0007k7-Fd for qemu-devel@nongnu.org; Wed, 06 Jan 2016 22:23:14 -0500 References: <1452047951-17429-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1452047951-17429-3-git-send-email-caoj.fnst@cn.fujitsu.com> <568D3874.1060806@redhat.com> From: Cao jin Message-ID: <568DDACB.1010103@cn.fujitsu.com> Date: Thu, 7 Jan 2016 11:26:03 +0800 MIME-Version: 1.0 In-Reply-To: <568D3874.1060806@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: stefano.stabellini@eu.citrix.com On 01/06/2016 11:53 PM, Eric Blake wrote: > On 01/05/2016 07:39 PM, Cao jin wrote: [...] > > Please no '!' in error messages. We aren't shouting at the user. Interesting, I didn`t think of this kind of questions before. will fix > >> XEN_PT_ERR(d, "Setup VGA BIOS of passthrough GFX failed!\n"); > > Do we still need the XEN_PT_ERR() alongside setting the local error? > this is fixed in "4/4 convert to realize" patch, as I said in last mail, I try to make every patch as small as possible >> xen_host_pci_device_put(&s->real_device); >> return -1; > > This leaks local_err. > > [...] -- Yours Sincerely, Cao jin