From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbcAGDgh (ORCPT ); Wed, 6 Jan 2016 22:36:37 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:1943 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbcAGDgf (ORCPT ); Wed, 6 Jan 2016 22:36:35 -0500 Subject: Re: [PATCH v4 2/5] doc: bindings: Document for hi655x regulator driver To: Mark Brown References: <1451910472-126417-1-git-send-email-puck.chen@hisilicon.com> <1451910472-126417-3-git-send-email-puck.chen@hisilicon.com> <20160105154719.GC6588@sirena.org.uk> CC: , , , , , , , , , , , , , , , , , , , , From: chenfeng Message-ID: <568DDD2D.9050902@hisilicon.com> Date: Thu, 7 Jan 2016 11:36:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160105154719.GC6588@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.192.172] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0206.568DDD3F.0099,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 67433598ff1bbc6ae606eb222db78c4f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/5 23:47, Mark Brown wrote: > On Mon, Jan 04, 2016 at 08:27:49PM +0800, Chen Feng wrote: >> Add Document for hi655x pmic regulator driver > > As indicated in the driver review this seems to be a bit of an unusual > binding that I think needs reworking, also it needs a bit more detail - > for example, listing which regulator names are valid. > > Please also use subject lines reflecting the normal style for the > subsystem. > OK,Thanks.