From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 02/13] libxc: support new xenstore domain
 flag in libxc
Date: Thu, 7 Jan 2016 07:08:07 +0100
Message-ID: <568E00C7.4050504@suse.com>
References: <1450444471-6454-1-git-send-email-jgross@suse.com>
	<1450444471-6454-3-git-send-email-jgross@suse.com>
	<1452095533.21055.92.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1452095533.21055.92.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On 06/01/16 16:52, Ian Campbell wrote:
> On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
>> Support the xenstore domain flag for obtaining domain info.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>  tools/libxc/include/xenctrl.h |  2 +-
>>  tools/libxc/xc_domain.c       | 17 +++++++++--------
>>  2 files changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/libxc/include/xenctrl.h
>> b/tools/libxc/include/xenctrl.h
>> index 01a6dda..45d8ff6 100644
>> --- a/tools/libxc/include/xenctrl.h
>> +++ b/tools/libxc/include/xenctrl.h
>> @@ -456,7 +456,7 @@ typedef struct xc_dominfo {
>>      uint32_t      ssidref;
>>      unsigned int  dying:1, crashed:1, shutdown:1,
>>                    paused:1, blocked:1, running:1,
>> -                  hvm:1, debugged:1, pvh:1;
>> +                  hvm:1, debugged:1, pvh:1, xs_domain:1;
> 
> All the other flags omit the _domain/_guest since it is implicit in the
> context I think.
> 
> "xs" would be ok, so would "xenstore" or "xenstored" I think.
> 
> You might want to consider similar arguments for DOMINF and the create
> flag, or you might want to argue that this field should be xs_domain for
> consistency with those.

In case there are no objections from others, I'll go with "xenstore".

> 
> Apart from what colour to paint the shed to code looks trivially correct.

Can I take this as an "Ack"?


Juergen