From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 09/13] xenstore: make use of the
 "xenstore domain" flag
Date: Thu, 7 Jan 2016 07:36:43 +0100
Message-ID: <568E077B.7080102@suse.com>
References: <1450444471-6454-1-git-send-email-jgross@suse.com>
	<1450444471-6454-10-git-send-email-jgross@suse.com>
	<1452097405.21055.108.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1452097405.21055.108.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On 06/01/16 17:23, Ian Campbell wrote:
> On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
>> Create the xenstore domain with the xs_domain flag specified. This
>> enables us to test whether such a domain is already running before
>> we create it. As there ought to be only one xenstore in the system
>> we don't need to start another one.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>  tools/helpers/init-xenstore-domain.c | 25 +++++++++++++++++++++++--
>>  1 file changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-
>> xenstore-domain.c
>> index 17f0151..4cd9e0f 100644
>> --- a/tools/helpers/init-xenstore-domain.c
>> +++ b/tools/helpers/init-xenstore-domain.c
>> @@ -66,7 +66,8 @@ static int build(xc_interface *xch)
>>      } else {
>>          ssid = SECINITSID_DOMU;
>>      }
>> -    rv = xc_domain_create(xch, ssid, handle, 0, &domid, NULL);
>> +    rv = xc_domain_create(xch, ssid, handle, XEN_DOMCTL_CDF_xs_domain,
>> +                  &domid, NULL);
>>      if (rv) {
>>          fprintf(stderr, "xc_domain_create failed\n");
>>          goto err;
>> @@ -165,6 +166,21 @@ err:
>>      return rv;
>>  }
>>  
>> +static int check_domain(xc_interface *xch)
>> +{
>> +    xc_dominfo_t info;
>> +    uint32_t dom;
>> +
>> +    dom = 0;
> 
> You can pretty safely skip dom0 I think?

Hmm, yes.

> 
>> +    while (xc_domain_getinfo(xch, dom, 1, &info) == 1) {
> 
> Logging errors (i.e. on return < 0) would be nice I think.

Okay.


Juergen