From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: drop smp_mb in vdso_init
Date: Thu, 7 Jan 2016 09:41:37 +0100 [thread overview]
Message-ID: <568E24C1.7090109@de.ibm.com> (raw)
In-Reply-To: <1452010645-25380-1-git-send-email-mst@redhat.com>
On 01/05/2016 05:17 PM, Michael S. Tsirkin wrote:
> The initial s390 vdso code is heavily influenced by the powerpc version
> which does have a smp_wmb in vdso_init right before the vdso_ready=1
> assignment. s390 has no need for that.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Untested.
>
> arch/s390/kernel/vdso.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
> index 59eddb0..a1cfd37 100644
> --- a/arch/s390/kernel/vdso.c
> +++ b/arch/s390/kernel/vdso.c
> @@ -299,8 +299,6 @@ static int __init vdso_init(void)
>
> get_page(virt_to_page(vdso_data));
>
> - smp_mb();
> -
> return 0;
> }
> early_initcall(vdso_init);
>
applied to the s390 tree.
Thanks.
prev parent reply other threads:[~2016-01-07 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 16:17 [PATCH] s390: drop smp_mb in vdso_init Michael S. Tsirkin
2016-01-07 8:41 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E24C1.7090109@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.