From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 2/4] libxc: support of linear p2m list
 for migration of pv-domains
Date: Thu, 7 Jan 2016 11:21:04 +0100
Message-ID: <568E3C10.5040305@suse.com>
References: <1450257860-11389-1-git-send-email-jgross@suse.com>
	<1450257860-11389-3-git-send-email-jgross@suse.com>
	<20160106154009.GJ27789@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160106154009.GJ27789@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 06/01/16 16:40, Wei Liu wrote:
> On Wed, Dec 16, 2015 at 10:24:18AM +0100, Juergen Gross wrote:
> [...]
>> @@ -698,21 +868,19 @@ static int normalise_pagetable(struct xc_sr_context *ctx, const uint64_t *src,
>>              /* 32bit guests can only use the first 4 entries of their L3 tables.
>>               * All other are potentially used by Xen. */
>>              xen_first = 4;
>> -            xen_last = 512;
>> +            xen_last = 511;
> 
> Is this a bug fix in its own right?

Hmm, bug fix is too much. It is a harmonization with the change below
using macros to set xen_last to 511 at maximum. In fact it doesn't
matter, because xen_last is used in:

   if ( i >= xen_first && i <= xen_last )

with i being in the range from 0 to 511.


Juergen

> 
> Wei.
> 
>>              break;
>>  
>>          case XEN_DOMCTL_PFINFO_L2TAB:
>>              /* It is hard to spot Xen mappings in a 32bit guest's L2.  Most
>>               * are normal but only a few will have Xen mappings.
>> -             *
>> -             * 428 = (HYPERVISOR_VIRT_START_PAE >> L2_PAGETABLE_SHIFT_PAE)&0x1ff
>> -             *
>> -             * ...which is conveniently unavailable to us in a 64bit build.
>>               */
>> -            if ( pte_to_frame(src[428]) == ctx->x86_pv.compat_m2p_mfn0 )
>> +            i = (HYPERVISOR_VIRT_START_X86_32 >> L2_PAGETABLE_SHIFT_PAE) & 511;
>> +            if ( pte_to_frame(src[i]) == ctx->x86_pv.compat_m2p_mfn0 )
>>              {
>> -                xen_first = 428;
>> -                xen_last = 512;
>> +                xen_first = i;
>> +                xen_last = (HYPERVISOR_VIRT_END_X86_32 >>
>> +                            L2_PAGETABLE_SHIFT_PAE) & 511;
>>              }
>>              break;
>>          }
>> -- 
>> 2.6.2
>>
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>