From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHAIa-0006ZF-OR for qemu-devel@nongnu.org; Thu, 07 Jan 2016 08:08:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHAIW-00018C-Va for qemu-devel@nongnu.org; Thu, 07 Jan 2016 08:08:16 -0500 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:35928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHAIW-000186-Ow for qemu-devel@nongnu.org; Thu, 07 Jan 2016 08:08:12 -0500 Received: by mail-wm0-x233.google.com with SMTP id l65so96262971wmf.1 for ; Thu, 07 Jan 2016 05:08:12 -0800 (PST) Sender: Paolo Bonzini References: <1450877240-12379-1-git-send-email-berrange@redhat.com> <568E3E82.5020300@redhat.com> From: Paolo Bonzini Message-ID: <568E6338.4080407@redhat.com> Date: Thu, 7 Jan 2016 14:08:08 +0100 MIME-Version: 1.0 In-Reply-To: <568E3E82.5020300@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] qemu-char: add logfile facility to all chardev backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster On 07/01/2016 11:31, Paolo Bonzini wrote: > > > On 23/12/2015 14:27, Daniel P. Berrange wrote: >> - mon_chr = qemu_chr_alloc(); >> + mon_chr = qemu_chr_alloc(&common, NULL); > > Changed NULL to &error_abort, and queued. Hmm, nope... this is missing documentation of the new options (though it does mention them in the help). Can you add it for v4? Paolo > Paolo > >> mon_chr->chr_write = gdb_monitor_write; > >