From: Georgi Djakov <georgi.djakov@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: andy.gross@linaro.org, lina.iyer@linaro.org,
sboyd@codeaurora.org, linux-soc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: Add support for SAW2 regulators
Date: Thu, 7 Jan 2016 15:47:59 +0200 [thread overview]
Message-ID: <568E6C8F.6020509@linaro.org> (raw)
In-Reply-To: <20151218172206.GD5727@sirena.org.uk>
On 12/18/2015 07:22 PM, Mark Brown wrote:
> On Fri, Dec 18, 2015 at 06:14:58PM +0200, Georgi Djakov wrote:
>> The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper)
>> is part of the SPM subsystem. It is a hardware block found on some of the
>> Qualcomm chipsets, which regulates the power to the CPU cores. Add some
>> basic support for it, so that we can do dynamic voltage scaling.
>>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>> ---
>> drivers/soc/qcom/spm.c | 149 +++++++++++++++++++++++++++++++++++++++++++++++-
>
> Please don't implement regualtors outside of the regulator driver
> directory unless there is a really strong reason to do so, it makes it
> much easier to maintain the subsystem and keep track of what's going on.
>
The reason of implementing the regulator functionality in drivers/soc is
that it is part of the same hardware. The saw2 hardware manages the power
controls - switching to low-power sleep modes, adaptive voltage scaling,
voltage control and messaging to the PMIC. Keeping all the functionality
of this hardware into a single driver seemed the suitable approach to me.
But if you think this is not a strong reason, then the approach probably
would be to export parts of the existing driver and use syscon from a
separate driver in drivers/regulator?
Thanks,
Georgi
next prev parent reply other threads:[~2016-01-07 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 16:14 [PATCH] soc: qcom: Add support for SAW2 regulators Georgi Djakov
2015-12-18 17:22 ` Mark Brown
2016-01-07 13:47 ` Georgi Djakov [this message]
2016-01-12 2:34 ` Stephen Boyd
2015-12-18 17:24 ` Lina Iyer
2016-01-07 13:50 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E6C8F.6020509@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.