From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [OSSTEST PATCH v3] support XSM/FLASK via Kconfig Date: Thu, 7 Jan 2016 09:37:17 -0600 Message-ID: <568E862D.10206@cardoe.com> References: <1452107994-2681-1-git-send-email-cardoe@cardoe.com> <1452161052.21055.154.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3993973109466907092==" Return-path: In-Reply-To: <1452161052.21055.154.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3993973109466907092== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mhQ0M2INtj6qNk3UcEQeqcuqAheWIXDlk" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mhQ0M2INtj6qNk3UcEQeqcuqAheWIXDlk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/7/16 4:04 AM, Ian Campbell wrote: > On Wed, 2016-01-06 at 13:19 -0600, Doug Goldstein wrote: >> In antcipation of XSM and FLASK migrating to Kconfig add support for >=20 > "anticipation" >=20 >> building them via Kconfig or the existing mechanism. >> >> Signed-off-by: Doug Goldstein >> --- >> Still untested but visually looks correct. >=20 > To me as well. I have a couple of questions though. >=20 >> Changes since v3: >> - Wrap all hunks of code with checks for Kconfig to not dirty the tree= >> >> Changes since v2: >> - Support Xen versions prior to Kconfig being integrated >> --- >> ts-xen-build | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/ts-xen-build b/ts-xen-build >> index 80b1faa..bc4e41a 100755 >> --- a/ts-xen-build >> +++ b/ts-xen-build >> @@ -55,6 +55,10 @@ sub checkout () { >> echo >>.config KERNELS=3D'' >> END >> (nonempty($r{enable_xsm}) ? <> + if test -f xen/Kconfig; then >> + echo >>xen/.config CONFIG_XSM=3D'${build_xsm}' >> + echo >>xen/.config CONFIG_FLASK=3D'${build_xsm}' >=20 > These are meaningless in a tree which has Kconfig but not yet the patch= es > to make XSM configured that way. However the subsequent olddefconfig wi= ll > just cause them to be dropped from the eventual .config. >=20 > Which then answers my second question which is: is this... >=20 >> + fi >> echo >>.config XSM_ENABLE=3D'${build_xsm}' >=20 > ... echo still needed if xen/Kconfig exists? The answer I think is yes > precisely because of the window of time mention above. yes due to the difference between Kconfig landing and XSM changing to take advantage due to >=20 > I suppose it will be possible to detect of this echo is needed with "gr= ep > -q XSM_ENABLE Config.mk", but maybe that can wait for another time. I thought it was harmless to include it so I didn't bother with the grep. I can roll a v4 with that if you'd prefer. >=20 > Also I conclude that this osstest patch should be a blocker for the xen= =2Egit > change, since if xen.git is patched first our XSM builds will unexpecte= dly > be non-Xsm builds. Yes. >=20 >> END >> (nonempty($r{tree_qemu}) ? <> @@ -126,6 +130,9 @@ END >> END >> #/; >> buildcmd_stamped_logged(9000, 'build', '',<> + if test -f xen/Kconfig; then >> + $make_prefix make -C xen olddefconfig >> + fi >> $make_prefix make $makeflags @ARGV >> END >> =20 So I guess my question is do I need to roll a v4 or is this ok (save for the spelling mistake in the commit msg). --=20 Doug Goldstein --mhQ0M2INtj6qNk3UcEQeqcuqAheWIXDlk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWjoYwXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU43sQAI7liFCpwxh+1qnb1OttNe77 fnfkrupEoSZtndXXz4urh7KW4YSHzty41quw9R7DBRRiqLYZNHDGz/nYKt86hoO0 AkVrBtO7qpq9EqWy7rzdtKGREdImm+lGglLq8S0sotGNpuH8dxbwKyxwg164Tpmn 2OIzzu4K2bwsgWKvRDgGaDUfJBNqvSzjgfhMb5TsEHeHycB6EadNbW+FikpLFyhF HXbLuzIu7iYv1zz0he5+kD2T1nwe/n3SnaTCMqBCWHw1Pyv59tr1sA/1sBftqZc1 OWn0JCSLrWsbKM0+WCNOo9p6NKYzLXpEMvFAjHpjIGdi2WoBDZAdYBiCOoqzxEvA nmhjhW9TAqzbifhvsI6hoVebz/tOxuBqecQdoTmrksQzjVh/DaQxj8zzeKxImTM5 9sPvKLUD45adSS9udC+WJbXPaSp4vuAVv/1ZzIUXKgaX/8M16wKh6pDUHiiiqWi4 ueQwZKFySK9yBXvf5r+2eM+pQr0DfajaQn60GbdlRFvDa2lTOKPRdct+f0D6ZGrX QbVVn9uHGbDa82AlS9bQgKYUss+ESR4JtjUfVmOjWBr7rGSs1OqZSZwQc+ffwfFX /A/h9OAm7eiq45WSdVLzpysClw4XTkNH6RhvwBfw//x8p4bj1mpNA2q6qUBWbo49 xEFc9sSBfo/WfQsWWtfu =LC1j -----END PGP SIGNATURE----- --mhQ0M2INtj6qNk3UcEQeqcuqAheWIXDlk-- --===============3993973109466907092== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3993973109466907092==--