All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2] network: Fix use-after-free caused by Scan() in poor reception.
Date: Thu, 07 Jan 2016 10:32:43 -0600	[thread overview]
Message-ID: <568E932B.7000203@gmail.com> (raw)
In-Reply-To: <1452163577-23146-2-git-send-email-john.ernberg@actia.se>

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi John,

On 01/07/2016 04:46 AM, John Ernberg wrote:
> From: John Ernberg <john.ernberg@actia.se>
>
> When issuing a Scan() in poor reception while attached to an operator it's
> fully possible to get no results, which causes the attached operator to be
> cleaned up. In certain scenarios this would cause a use-after-free as there
> are still references to this operator.
> Transfer the attached operator to the new list regardless of removal caused
> by the Scan() results.
> ---
>   src/network.c | 16 ++++++++++++++--
>   1 file changed, 14 insertions(+), 2 deletions(-)
>

Looks good to me.  I tweaked the commit header slightly and applied the 
patch.

Thanks!

Regards,
-Denis

      reply	other threads:[~2016-01-07 16:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 10:46 [PATCH v2] network: Fix use-after-free caused by Scan() in poor reception John Ernberg
2016-01-07 10:46 ` John Ernberg
2016-01-07 16:32   ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568E932B.7000203@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.