From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 3/7] kvm/x86: Hyper-V unify stimer_start() and
 stimer_restart()
Date: Thu, 7 Jan 2016 17:40:36 +0100
Message-ID: <568E9504.30900@redhat.com>
References: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com>
 <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@kernel.org>, Roman Kagan <rkagan@virtuozzo.com>,
	"Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
To: Andrey Smetanin <asmetanin@virtuozzo.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42076 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750961AbcAGQkm (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 7 Jan 2016 11:40:42 -0500
In-Reply-To: <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 28/12/2015 16:27, Andrey Smetanin wrote:
> This will be used in future to start Hyper-V SynIC timer
> in several places by one logic in one function.
> 
> Changes v2:
> * drop stimer->count == 0 check inside stimer_start()
> * comment stimer_start() assumptions

Can you replace comments with WARN_ON_ONCE?

Paolo

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aHDcE-00070h-FO
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:40:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aHDcB-0005Nx-6P
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:40:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aHDcA-0005Nl-Vo
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:40:43 -0500
References: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com>
	<1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <568E9504.30900@redhat.com>
Date: Thu, 7 Jan 2016 17:40:36 +0100
MIME-Version: 1.0
In-Reply-To: <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/7] kvm/x86: Hyper-V unify
 stimer_start() and stimer_restart()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrey Smetanin <asmetanin@virtuozzo.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>, "Denis V. Lunev" <den@openvz.org>, Roman Kagan <rkagan@virtuozzo.com>, qemu-devel@nongnu.org



On 28/12/2015 16:27, Andrey Smetanin wrote:
> This will be used in future to start Hyper-V SynIC timer
> in several places by one logic in one function.
> 
> Changes v2:
> * drop stimer->count == 0 check inside stimer_start()
> * comment stimer_start() assumptions

Can you replace comments with WARN_ON_ONCE?

Paolo