From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 0/7] KVM: Hyper-V SynIC timers migration fixes Date: Thu, 7 Jan 2016 17:42:17 +0100 Message-ID: <568E9569.9040603@redhat.com> References: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Roman Kagan , "Denis V. Lunev" , qemu-devel@nongnu.org To: Andrey Smetanin , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42270 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcAGQmY (ORCPT ); Thu, 7 Jan 2016 11:42:24 -0500 In-Reply-To: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com> Sender: kvm-owner@vger.kernel.org List-ID: On 28/12/2015 16:27, Andrey Smetanin wrote: > During testing of Windows 2012R2 guest migration with > Hyper-V SynIC timers enabled we found several bugs > which lead to restoring guest in a hung state. > > This patch series provides several fixes to make the > migration of guest with Hyper-V SynIC timers enabled > succeed. > > The series applies on top of > 'kvm/x86: Remove Hyper-V SynIC timer stopping' > previously sent. > > Changes v2: > * fix incorrect logical operation for one-shot timers > * drop stimer->count == 0 inside stimer_start() > * comment stimer_start() assumtions > > Signed-off-by: Andrey Smetanin > Reviewed-by: Roman Kagan > CC: Gleb Natapov > CC: Paolo Bonzini > CC: Roman Kagan > CC: Denis V. Lunev > CC: qemu-devel@nongnu.org > > Andrey Smetanin (7): > kvm/x86: Hyper-V timers fix incorrect logical operation > kvm/x86: Drop stimer_stop() function > kvm/x86: Hyper-V unify stimer_start() and stimer_restart() > kvm/x86: Reorg stimer_expiration() to better control timer restart > kvm/x86: Hyper-V fix SynIC timer disabling condition > kvm/x86: Skip SynIC vector check for QEMU side > kvm/x86: Update SynIC timers on guest entry only > > arch/x86/kvm/hyperv.c | 119 ++++++++++++++++++++++++-------------------------- > arch/x86/kvm/x86.c | 6 +++ > 2 files changed, 63 insertions(+), 62 deletions(-) > Applied this instead of v1. :) Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDds-0000Ko-5i for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:42:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDdo-00064Y-Qr for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:42:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDdo-00064D-Kk for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:42:24 -0500 References: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com> From: Paolo Bonzini Message-ID: <568E9569.9040603@redhat.com> Date: Thu, 7 Jan 2016 17:42:17 +0100 MIME-Version: 1.0 In-Reply-To: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/7] KVM: Hyper-V SynIC timers migration fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Smetanin , kvm@vger.kernel.org Cc: Gleb Natapov , "Denis V. Lunev" , Roman Kagan , qemu-devel@nongnu.org On 28/12/2015 16:27, Andrey Smetanin wrote: > During testing of Windows 2012R2 guest migration with > Hyper-V SynIC timers enabled we found several bugs > which lead to restoring guest in a hung state. > > This patch series provides several fixes to make the > migration of guest with Hyper-V SynIC timers enabled > succeed. > > The series applies on top of > 'kvm/x86: Remove Hyper-V SynIC timer stopping' > previously sent. > > Changes v2: > * fix incorrect logical operation for one-shot timers > * drop stimer->count == 0 inside stimer_start() > * comment stimer_start() assumtions > > Signed-off-by: Andrey Smetanin > Reviewed-by: Roman Kagan > CC: Gleb Natapov > CC: Paolo Bonzini > CC: Roman Kagan > CC: Denis V. Lunev > CC: qemu-devel@nongnu.org > > Andrey Smetanin (7): > kvm/x86: Hyper-V timers fix incorrect logical operation > kvm/x86: Drop stimer_stop() function > kvm/x86: Hyper-V unify stimer_start() and stimer_restart() > kvm/x86: Reorg stimer_expiration() to better control timer restart > kvm/x86: Hyper-V fix SynIC timer disabling condition > kvm/x86: Skip SynIC vector check for QEMU side > kvm/x86: Update SynIC timers on guest entry only > > arch/x86/kvm/hyperv.c | 119 ++++++++++++++++++++++++-------------------------- > arch/x86/kvm/x86.c | 6 +++ > 2 files changed, 63 insertions(+), 62 deletions(-) > Applied this instead of v1. :) Paolo