From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDoh-0007p3-Qx for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:53:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDoc-0000mw-Dn for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:53:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDoc-0000mq-8b for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:53:34 -0500 References: <1452047951-17429-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1452047951-17429-5-git-send-email-caoj.fnst@cn.fujitsu.com> <568D3BD6.1050707@redhat.com> <568E10B6.5010900@cn.fujitsu.com> From: Eric Blake Message-ID: <568E980C.2080009@redhat.com> Date: Thu, 7 Jan 2016 09:53:32 -0700 MIME-Version: 1.0 In-Reply-To: <568E10B6.5010900@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GnK9V1nrx4xXxWTgwH7kWocWEFhvniSQ2" Subject: Re: [Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: stefano.stabellini@eu.citrix.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GnK9V1nrx4xXxWTgwH7kWocWEFhvniSQ2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/07/2016 12:16 AM, Cao jin wrote: >=20 >=20 > On 01/07/2016 12:07 AM, Eric Blake wrote: >> On 01/05/2016 07:39 PM, Cao jin wrote: > [...] >> >>> @@ -827,27 +827,26 @@ static int xen_pt_initfn(PCIDevice *d) >>> xen_pt_config_init(s, &local_err); >>> if (local_err) { >>> error_append_hint(&local_err, "PCI Config space >>> initialisation failed"); >>> - rc =3D -1; >>> + error_propagate(errp, local_err); >>> goto err_out; >>> } >> >> Looks like this fixes a memory leak in an earlier patch; maybe you nee= d >> to shuffle hunks around? >> >=20 > Sorry, don`t quite undertand what "shuffle hunks around" means, could > you detail it? It means this change should occur in an earlier patch (probably 2/4?). I shuffle hunks by using 'git rebase -i'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GnK9V1nrx4xXxWTgwH7kWocWEFhvniSQ2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWjpgNAAoJEKeha0olJ0NqIZ8H/3TR8DW3OIIMQmVh+OpVmD18 LVR1uvyhREJwLvcHgo2vUaI3X/OTxUzmFz/0aZMRPBkQa9Q1yjd7Nztt3bKAwAZ5 MhtwkBA9RkICoydVbOsRbJA5QW6CqWjWDNPrGpwIky3Zl7uyz/JdhMyLsMN+j9iL xHiUhJr9akdaOEiDrWFGZShXKk4vmtWeLidZGANiWhf51pIIxacXV/e2qR/b/Aph aQW3hZ1B735uIxjSfGp2DMRBTlm+jtB+XgOvxoLG0rH3OGmR050gVs3b91TZ/jZk A6OZ/PXVqQZEUL3ixu9A6bIR+3gS0uSAzwTJ80LsZQlHaYzqwvViPRURhJwUbyI= =O832 -----END PGP SIGNATURE----- --GnK9V1nrx4xXxWTgwH7kWocWEFhvniSQ2--