From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/6] drm/i915: Avoid invariant conditionals in lrc interrupt handler Date: Thu, 7 Jan 2016 17:16:19 +0000 Message-ID: <568E9D63.6080908@linux.intel.com> References: <1452184581-21075-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1452184581-21075-4-git-send-email-tvrtko.ursulin@linux.intel.com> <20160107164259.GM652@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B7F266E6C8 for ; Thu, 7 Jan 2016 09:16:21 -0800 (PST) In-Reply-To: <20160107164259.GM652@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzAxLzE2IDE2OjQyLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBKYW4gMDcs IDIwMTYgYXQgMDQ6MzY6MThQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IFRoZXJlIGlz IG5vIG5lZWQgdG8gY2hlY2sgb24gd2hhdCBHZW4gd2UgYXJlIHJ1bm5pbmcgb24gZXZlcnkKPj4g aW50ZXJydXB0IGFuZCBldmVyeSBjb21tYW5kIHN1Ym1pc3Npb24uIFdlIGNhbiBpbnN0ZWFkIHNl dCB1cAo+PiBzb21lIG9mIHRoYXQgd2hlbiBlbmdpbmVzIGFyZSBpbml0aWFsaXplZCwgc3RvcmUg aXQgaW4gdGhlCj4+IGVuZ2luZSBzdHJ1Y3R1cmUgYW5kIHVzZSBpdCBkaXJlY3RseSBhdCBydW50 aW1lLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A aW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAg ICAgICAgfCAzNiArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggfCAgMiArKwo+PiAgIDIgZmlsZXMgY2hh bmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jCj4+IGluZGV4IDhiNjA3MWZjZDc0My4uODQ5NzdhNmU2ZjNmIDEwMDY0NAo+ PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+PiBAQCAtMjk4LDI5ICsyOTgsMTUgQEAgdWludDY0 X3QgaW50ZWxfbHJfY29udGV4dF9kZXNjcmlwdG9yKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgs Cj4+ICAgCQkJCSAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPj4gICB7Cj4+ICAg CXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpjdHhfb2JqID0gY3R4LT5lbmdpbmVbcmluZy0+ aWRdLnN0YXRlOwo+PiAtCXVpbnQ2NF90IGRlc2M7Cj4+ICsJdWludDY0X3QgZGVzYyA9IHJpbmct PmN0eF9kZXNjX3RlbXBsYXRlOwo+PiAgIAl1aW50NjRfdCBscmNhID0gaTkxNV9nZW1fb2JqX2dn dHRfb2Zmc2V0KGN0eF9vYmopICsKPj4gICAJCQlMUkNfUFBIV1NQX1BOICogUEFHRV9TSVpFOwo+ Pgo+PiAgIAlXQVJOX09OKGxyY2EgJiAweEZGRkZGRkZGMDAwMDBGRkZVTEwpOwo+Pgo+PiAtCWRl c2MgPSBHRU44X0NUWF9WQUxJRDsKPj4gLQlkZXNjIHw9IEdFTjhfQ1RYX0FERFJFU1NJTkdfTU9E RShkZXYpIDw8IEdFTjhfQ1RYX0FERFJFU1NJTkdfTU9ERV9TSElGVDsKPj4gLQlpZiAoSVNfR0VO OChjdHhfb2JqLT5iYXNlLmRldikpCj4+IC0JCWRlc2MgfD0gR0VOOF9DVFhfTDNMTENfQ09IRVJF TlQ7Cj4+IC0JZGVzYyB8PSBHRU44X0NUWF9QUklWSUxFR0U7Cj4+ICAgCWRlc2MgfD0gbHJjYTsK Pj4gICAJZGVzYyB8PSAodTY0KWludGVsX2V4ZWNsaXN0c19jdHhfaWQoY3R4X29iaikgPDwgR0VO OF9DVFhfSURfU0hJRlQ7Cj4+Cj4+IC0JLyogVE9ETzogV2FEaXNhYmxlTGl0ZVJlc3RvcmUgd2hl biB3ZSBzdGFydCB1c2luZyBzZW1hcGhvcmUKPj4gLQkgKiBzaWduYWxsaW5nIGJldHdlZW4gQ29t bWFuZCBTdHJlYW1lcnMgKi8KPj4gLQkvKiBkZXNjIHw9IEdFTjhfQ1RYX0ZPUkNFX1JFU1RPUkU7 ICovCj4+IC0KPj4gLQkvKiBXYUVuYWJsZUZvcmNlUmVzdG9yZUluQ3R4dERlc2NGb3JWQ1M6c2ts ICovCj4+IC0JLyogV2FFbmFibGVGb3JjZVJlc3RvcmVJbkN0eHREZXNjRm9yVkNTOmJ4dCAqLwo+ PiAtCWlmIChkaXNhYmxlX2xpdGVfcmVzdG9yZV93YShyaW5nKSkKPj4gLQkJZGVzYyB8PSBHRU44 X0NUWF9GT1JDRV9SRVNUT1JFOwo+PiAtCj4+ICAgCXJldHVybiBkZXNjOwo+PiAgIH0KPj4KPj4g QEAgLTU1Niw3ICs1NDIsNyBAQCB2b2lkIGludGVsX2xyY19pcnFfaGFuZGxlcihzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICpyaW5nKQo+PiAgIAkJfQo+PiAgIAl9Cj4+Cj4+IC0JaWYgKGRpc2FibGVf bGl0ZV9yZXN0b3JlX3dhKHJpbmcpKSB7Cj4+ICsJaWYgKHJpbmctPmRpc2FibGVfbGl0ZV9yZXN0 b3JlX3dhKSB7Cj4+ICAgCQkvKiBQcmV2ZW50IGEgY3R4IHRvIHByZWVtcHQgaXRzZWxmICovCj4+ ICAgCQlpZiAoKHN0YXR1cyAmIEdFTjhfQ1RYX1NUQVRVU19BQ1RJVkVfSURMRSkgJiYKPj4gICAJ CSAgICAoc3VibWl0X2NvbnRleHRzICE9IDApKQo+Cj4gRGlkbid0IGl0IG9jY3VyIHRvIHlvdSB0 aGF0IHRoaXMgY29kZSBpcyBnYXJiYWdlPwoKTm8sIG15IGRlZmF1bHQgcG9zaXRpb24gaXMgdGhh dCBJIGRvbid0IHVuZGVyc3RhbmQgaXQgd2VsbCBlbm91Z2guIElmIAp5b3UgbWVhbiB0aGF0IHRo ZSB0d28gaWYgc3RhdGVtZW50cyBoZXJlIGNhbiBiZSBtZXJnZWQgYW5kIGhhdmUgYSBzaW5nbGUg CmV4ZWNsaXN0c19jb250ZXh0X3VucXVldWUgY2FsbCBzaXRlLCBzdXJlLCBidXQgd2h5IG5vdCBk byBpdCBpbiBzaW1wbGVyIApzdGVwcy4KCj4KPj4gQEAgLTE5ODAsNiArMTk2NiwyNCBAQCBzdGF0 aWMgaW50IGxvZ2ljYWxfcmluZ19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKnJpbgo+PiAgIAkJZ290byBlcnJvcjsKPj4gICAJfQo+Pgo+PiArCXJp bmctPmRpc2FibGVfbGl0ZV9yZXN0b3JlX3dhID0gZGlzYWJsZV9saXRlX3Jlc3RvcmVfd2Eocmlu Zyk7Cj4+ICsKPj4gKwlyaW5nLT5jdHhfZGVzY190ZW1wbGF0ZSA9IEdFTjhfQ1RYX1ZBTElEOwo+ PiArCXJpbmctPmN0eF9kZXNjX3RlbXBsYXRlIHw9IEdFTjhfQ1RYX0FERFJFU1NJTkdfTU9ERShk ZXYpIDw8Cj4+ICsJCQkJICAgR0VOOF9DVFhfQUREUkVTU0lOR19NT0RFX1NISUZUOwo+PiArCWlm IChJU19HRU44KGRldikpCj4+ICsJCXJpbmctPmN0eF9kZXNjX3RlbXBsYXRlIHw9IEdFTjhfQ1RY X0wzTExDX0NPSEVSRU5UOwo+PiArCXJpbmctPmN0eF9kZXNjX3RlbXBsYXRlIHw9IEdFTjhfQ1RY X1BSSVZJTEVHRTsKPj4gKwo+PiArCS8qIFRPRE86IFdhRGlzYWJsZUxpdGVSZXN0b3JlIHdoZW4g d2Ugc3RhcnQgdXNpbmcgc2VtYXBob3JlCj4+ICsJICogc2lnbmFsbGluZyBiZXR3ZWVuIENvbW1h bmQgU3RyZWFtZXJzICovCj4+ICsJLyogcmluZy0+Y3R4X2Rlc2NfdGVtcGxhdGUgfD0gR0VOOF9D VFhfRk9SQ0VfUkVTVE9SRTsgKi8KPj4gKwo+PiArCS8qIFdhRW5hYmxlRm9yY2VSZXN0b3JlSW5D dHh0RGVzY0ZvclZDUzpza2wgKi8KPj4gKwkvKiBXYUVuYWJsZUZvcmNlUmVzdG9yZUluQ3R4dERl c2NGb3JWQ1M6Ynh0ICovCj4+ICsJaWYgKHJpbmctPmRpc2FibGVfbGl0ZV9yZXN0b3JlX3dhKQo+ PiArCQlyaW5nLT5jdHhfZGVzY190ZW1wbGF0ZSB8PSBHRU44X0NUWF9GT1JDRV9SRVNUT1JFOwo+ PiArCj4+ICAgCXJldHVybiAwOwo+Pgo+PiAgIGVycm9yOgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5oCj4+IGluZGV4IDQ5NTc0ZmZlNTRiYy4uMGI5MWE0Yjc3MzU5IDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4+IEBAIC0yNjgs NiArMjY4LDggQEAgc3RydWN0ICBpbnRlbF9lbmdpbmVfY3Mgewo+PiAgIAlzdHJ1Y3QgbGlzdF9o ZWFkIGV4ZWNsaXN0X3F1ZXVlOwo+PiAgIAlzdHJ1Y3QgbGlzdF9oZWFkIGV4ZWNsaXN0X3JldGly ZWRfcmVxX2xpc3Q7Cj4+ICAgCXU4IG5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyOwo+PiArCWJv b2wgZGlzYWJsZV9saXRlX3Jlc3RvcmVfd2E7Cj4KPiBZb3UgZG9uJ3QgbmVlZCB0aGF0IGFzIGEg c2VwYXJhdGUgZmxhZy4gWW91IGtub3cgSSBzZW50IHRoaXMgcGF0Y2ggbGFzdAo+IHllYXI/CgpO b3BlLiA6LwoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=