From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH v2 1/5] test: firmware_class: report errors properly on failure Date: Thu, 7 Jan 2016 13:54:29 -0700 Message-ID: <568ED085.4040801@osg.samsung.com> References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449701429-121423-1-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris , Greg Kroah-Hartman , Ming Lei Cc: Kees Cook , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Luis R. Rodriguez" , Shuah Khan List-Id: linux-api@vger.kernel.org On 12/09/2015 03:50 PM, Brian Norris wrote: > request_firmware() failures currently won't get reported at all (the > error code is discarded). What's more, we get confusing messages, like: > > # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request > [ 8280.311856] test_firmware: loading 'notafile' > [ 8280.317042] test_firmware: load of 'notafile' failed: -2 > [ 8280.322445] test_firmware: loaded: 0 > # echo $? > 0 > > Report the failures via write() errors, and don't say we "loaded" > anything. > > Signed-off-by: Brian Norris > Acked-by: Kees Cook Thanks for fixing it. Applied to linux-kselftest next for 4.5-rc1. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbcAGUyd (ORCPT ); Thu, 7 Jan 2016 15:54:33 -0500 Received: from lists.s-osg.org ([54.187.51.154]:47184 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbcAGUyb (ORCPT ); Thu, 7 Jan 2016 15:54:31 -0500 Subject: Re: [PATCH v2 1/5] test: firmware_class: report errors properly on failure To: Brian Norris , Greg Kroah-Hartman , Ming Lei References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, "Luis R. Rodriguez" , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <568ED085.4040801@osg.samsung.com> Date: Thu, 7 Jan 2016 13:54:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2015 03:50 PM, Brian Norris wrote: > request_firmware() failures currently won't get reported at all (the > error code is discarded). What's more, we get confusing messages, like: > > # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request > [ 8280.311856] test_firmware: loading 'notafile' > [ 8280.317042] test_firmware: load of 'notafile' failed: -2 > [ 8280.322445] test_firmware: loaded: 0 > # echo $? > 0 > > Report the failures via write() errors, and don't say we "loaded" > anything. > > Signed-off-by: Brian Norris > Acked-by: Kees Cook Thanks for fixing it. Applied to linux-kselftest next for 4.5-rc1. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978