From: "H. Peter Anvin" <hpa@zytor.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Andy Lutomirski <luto@amacapital.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"H . Peter Anvin" <hpa@linux.intel.com>,
Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Imre Deak <imre.deak@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] x86: Add an explicit barrier() to clflushopt()
Date: Thu, 7 Jan 2016 13:05:35 -0800 [thread overview]
Message-ID: <568ED31F.1090004@zytor.com> (raw)
In-Reply-To: <20160107194413.GA25144@nuc-i3427.alporthouse.com>
On 01/07/16 11:44, Chris Wilson wrote:
>
> Now I feel silly. Looking at the .s, there is no difference with the
> addition of the barrier to clflush_cache_range(). And sure enough
> letting the test run for longer, we see a failure. I fell for a placebo.
>
> The failing assertion is always on the last cacheline and is always one
> value behind. Oh well, back to wondering where we miss the flush.
> -Chris
>
Could you include the assembly here?
-hpa
next prev parent reply other threads:[~2016-01-07 21:05 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 9:58 [PATCH] x86: Add an explicit barrier() to clflushopt() Chris Wilson
2015-10-19 9:58 ` Chris Wilson
2015-10-19 10:16 ` Borislav Petkov
2015-10-19 10:16 ` Borislav Petkov
2015-10-19 11:05 ` Chris Wilson
2015-10-19 11:05 ` Chris Wilson
2015-10-19 11:25 ` Borislav Petkov
2015-10-19 11:25 ` Borislav Petkov
2015-10-19 18:29 ` Ross Zwisler
2016-01-07 10:16 ` Chris Wilson
2016-01-07 10:16 ` Chris Wilson
2016-01-07 17:55 ` Andy Lutomirski
2016-01-07 17:55 ` Andy Lutomirski
2016-01-07 19:44 ` Chris Wilson
2016-01-07 19:44 ` Chris Wilson
2016-01-07 21:05 ` H. Peter Anvin [this message]
2016-01-07 21:54 ` Chris Wilson
2016-01-07 21:54 ` Chris Wilson
2016-01-07 22:29 ` H. Peter Anvin
2016-01-07 22:29 ` H. Peter Anvin
2016-01-07 22:32 ` H. Peter Anvin
2016-01-07 22:32 ` H. Peter Anvin
2016-01-09 5:55 ` H. Peter Anvin
2016-01-09 8:01 ` Chris Wilson
2016-01-09 8:01 ` Chris Wilson
2016-01-09 22:36 ` Andy Lutomirski
2016-01-09 22:36 ` Andy Lutomirski
2016-01-11 11:28 ` Chris Wilson
2016-01-11 11:28 ` Chris Wilson
2016-01-11 20:11 ` Linus Torvalds
2016-01-11 20:11 ` Linus Torvalds
2016-01-11 21:05 ` Chris Wilson
2016-01-11 21:05 ` Chris Wilson
2016-01-12 16:37 ` Chris Wilson
2016-01-12 16:37 ` Chris Wilson
2016-01-12 17:05 ` Linus Torvalds
2016-01-12 17:05 ` Linus Torvalds
2016-01-12 21:13 ` Chris Wilson
2016-01-12 21:13 ` Chris Wilson
2016-01-12 22:07 ` Linus Torvalds
2016-01-12 22:07 ` Linus Torvalds
2016-01-13 0:55 ` Chris Wilson
2016-01-13 0:55 ` Chris Wilson
2016-01-13 2:06 ` Linus Torvalds
2016-01-13 2:06 ` Linus Torvalds
2016-01-13 2:42 ` Andy Lutomirski
2016-01-13 2:42 ` Andy Lutomirski
2016-01-13 4:39 ` Linus Torvalds
2016-01-13 4:39 ` Linus Torvalds
2016-01-13 12:34 ` Chris Wilson
2016-01-13 12:34 ` Chris Wilson
2016-01-13 18:45 ` Linus Torvalds
2016-01-13 18:45 ` Linus Torvalds
2016-01-12 17:17 ` H. Peter Anvin
2016-01-12 17:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568ED31F.1090004@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvlasenk@redhat.com \
--cc=hpa@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.