From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHMkG-00022t-FN for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:25:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHMkE-0005ai-Ub for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:25:40 -0500 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:33156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHMkE-0005aV-OY for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:25:38 -0500 Received: by mail-pa0-x234.google.com with SMTP id cy9so273467502pac.0 for ; Thu, 07 Jan 2016 18:25:38 -0800 (PST) References: <1452104533-8516-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1452104533-8516-3-git-send-email-mark.cave-ayland@ilande.co.uk> From: Alexey Kardashevskiy Message-ID: <568F1E1C.6000308@ozlabs.ru> Date: Fri, 8 Jan 2016 13:25:32 +1100 MIME-Version: 1.0 In-Reply-To: <1452104533-8516-3-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] target-ppc: use cpu_write_xer() helper in cpu_post_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de, quintela@redhat.com, amit.shah@redhat.com On 01/07/2016 05:22 AM, Mark Cave-Ayland wrote: > Otherwise some internal xer variables fail to get set post-migration. > > Signed-off-by: Mark Cave-Ayland > --- > target-ppc/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > index 98fc63a..322ce84 100644 > --- a/target-ppc/machine.c > +++ b/target-ppc/machine.c > @@ -168,7 +168,7 @@ static int cpu_post_load(void *opaque, int version_id) > env->spr[SPR_PVR] = env->spr_cb[SPR_PVR].default_value; > env->lr = env->spr[SPR_LR]; > env->ctr = env->spr[SPR_CTR]; > - env->xer = env->spr[SPR_XER]; > + cpu_write_xer(env, env->spr[SPR_XER]); > #if defined(TARGET_PPC64) > env->cfar = env->spr[SPR_CFAR]; > #endif > Reviewed-by: Alexey Kardashevskiy -- Alexey