From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHMoB-0003C0-Mz for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:29:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHMo7-00078h-73 for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:29:43 -0500 Received: from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]:34194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHMo7-00075t-1n for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:29:39 -0500 Received: by mail-pf0-x22e.google.com with SMTP id q63so2497939pfb.1 for ; Thu, 07 Jan 2016 18:29:37 -0800 (PST) References: <1452104533-8516-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1452104533-8516-4-git-send-email-mark.cave-ayland@ilande.co.uk> From: Alexey Kardashevskiy Message-ID: <568F1F0C.6050501@ozlabs.ru> Date: Fri, 8 Jan 2016 13:29:32 +1100 MIME-Version: 1.0 In-Reply-To: <1452104533-8516-4-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] target-ppc: add CPU access_type into the migration stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de, quintela@redhat.com, amit.shah@redhat.com On 01/07/2016 05:22 AM, Mark Cave-Ayland wrote: > This is referenced in cpu_ppc_handle_mmu_fault() and so should be included > in the migration stream. > > Signed-off-by: Mark Cave-Ayland > --- > target-ppc/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > index 322ce84..cb56423 100644 > --- a/target-ppc/machine.c > +++ b/target-ppc/machine.c > @@ -530,7 +530,7 @@ const VMStateDescription vmstate_ppc_cpu = { > > /* Internal state */ > VMSTATE_UINTTL(env.hflags_nmsr, PowerPCCPU), > - /* FIXME: access_type? */ > + VMSTATE_INT32(env.access_type, PowerPCCPU), VMSTATE_INT32_V and you need to change access_type's type from "int" to "int32_t" (or better use "uint8_t" as it is a simple enum with 3 possible values). > > /* Interrupt state */ > VMSTATE_UINT32(env.pending_interrupts, PowerPCCPU), > -- Alexey