From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 1/6] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024 Date: Fri, 8 Jan 2016 11:36:55 +0530 Message-ID: <568F51FF.7000102@nvidia.com> References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-2-git-send-email-ldewangan@nvidia.com> <20160107231249.GA17514@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160107231249.GA17514@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-gpio@vger.kernel.org Thanks Rob for review. I have taken care of all comment except following which I have query. On Friday 08 January 2016 04:42 AM, Rob Herring wrote: > + - maxim,low-battery-reset-enable: Enable low battery reset. > + - maxim,low-battery-reset-disable: Disable low battery reset. > Why not boolean? Not present means keep default value? I'd prefer > boolean or tristate of not present, 0 to disable, or 1 to enable. > > Here, the properties are boolean. I will add this on the description. I like to enable or disable with the DT and properties are not there then left to default. So added two properties for enable and disable. If properties are there, do the activity. Here tristate is also possible: maxim,low-battery-reset: tristate, low battery reset control. 0 for disable, 1 for enable and absence of this will leave configuration on default. Does it look fine? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com. [216.228.121.143]) by gmr-mx.google.com with ESMTPS id a76si164322pfj.2.2016.01.07.22.17.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jan 2016 22:17:02 -0800 (PST) Message-ID: <568F51FF.7000102@nvidia.com> Date: Fri, 8 Jan 2016 11:36:55 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Rob Herring CC: , , , , , , , , , , , , , , , , Subject: [rtc-linux] Re: [PATCH 1/6] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024 References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-2-git-send-email-ldewangan@nvidia.com> <20160107231249.GA17514@rob-hp-laptop> In-Reply-To: <20160107231249.GA17514@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Thanks Rob for review. I have taken care of all comment except following which I have query. On Friday 08 January 2016 04:42 AM, Rob Herring wrote: > + - maxim,low-battery-reset-enable: Enable low battery reset. > + - maxim,low-battery-reset-disable: Disable low battery reset. > Why not boolean? Not present means keep default value? I'd prefer > boolean or tristate of not present, 0 to disable, or 1 to enable. > > Here, the properties are boolean. I will add this on the description. I like to enable or disable with the DT and properties are not there then left to default. So added two properties for enable and disable. If properties are there, do the activity. Here tristate is also possible: maxim,low-battery-reset: tristate, low battery reset control. 0 for disable, 1 for enable and absence of this will leave configuration on default. Does it look fine? -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbcAHGRE (ORCPT ); Fri, 8 Jan 2016 01:17:04 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:2901 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbcAHGRC (ORCPT ); Fri, 8 Jan 2016 01:17:02 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 07 Jan 2016 22:00:16 -0800 Message-ID: <568F51FF.7000102@nvidia.com> Date: Fri, 8 Jan 2016 11:36:55 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Rob Herring CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/6] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024 References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-2-git-send-email-ldewangan@nvidia.com> <20160107231249.GA17514@rob-hp-laptop> In-Reply-To: <20160107231249.GA17514@rob-hp-laptop> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Rob for review. I have taken care of all comment except following which I have query. On Friday 08 January 2016 04:42 AM, Rob Herring wrote: > + - maxim,low-battery-reset-enable: Enable low battery reset. > + - maxim,low-battery-reset-disable: Disable low battery reset. > Why not boolean? Not present means keep default value? I'd prefer > boolean or tristate of not present, 0 to disable, or 1 to enable. > > Here, the properties are boolean. I will add this on the description. I like to enable or disable with the DT and properties are not there then left to default. So added two properties for enable and disable. If properties are there, do the activity. Here tristate is also possible: maxim,low-battery-reset: tristate, low battery reset control. 0 for disable, 1 for enable and absence of this will leave configuration on default. Does it look fine?