From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHU81-0007Bw-RP for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:18:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHU7x-0002n1-Kr for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:18:41 -0500 Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:57068 helo=us-alimail-mta2.hst.scl.en.alidc.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHU7x-0002mj-5o for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:18:37 -0500 References: <1452218586-4009-1-git-send-email-chengang@emindsoft.com.cn> <568F758D.30405@vivier.eu> <568F8557.3000107@emindsoft.com.cn> <568F8804.8080101@vivier.eu> From: Chen Gang Message-ID: <568F8BC1.9020302@emindsoft.com.cn> Date: Fri, 8 Jan 2016 18:13:21 +0800 MIME-Version: 1.0 In-Reply-To: <568F8804.8080101@vivier.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] linux-user: syscall: Add SO_LINGER for setsockopt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , riku.voipio@iki.fi Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net On 2016年01月08日 17:57, Laurent Vivier wrote: > >>>> + return get_errno(setsockopt(sockfd, SOL_SOCKET, optname, >>>> + &lg, sizeof(lg))); >>> >>> Why do you use "SOL_SOCKET" instead of "level" ? >>> >> >> At present, level is TARGET_SOL_SOCKET, but we need SOL_SOCKET. > > Yes, you're right... so there is a bug in TARGET_SO_BINDTODEVICE which > is using "level" :) > OK, thanks. I shall send patch v2 for it, next week. -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed