From: Laurent Vivier <lvivier@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper
Date: Fri, 8 Jan 2016 11:22:21 +0100 [thread overview]
Message-ID: <568F8DDD.4020209@redhat.com> (raw)
In-Reply-To: <20160108110738.7db971fe.cornelia.huck@de.ibm.com>
On 08/01/2016 11:07, Cornelia Huck wrote:
> On Fri, 8 Jan 2016 10:21:40 +0100
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>
>> On Thu, 7 Jan 2016 21:07:26 +0100
>> Laurent Vivier <lvivier@redhat.com> wrote:
>
>>> IMHO, I think 4/6 and 5/6 can be merged as there is no change in the
>>> behavior and they are only consolidating code.
>>>
>>
>> Maybe but I'm not sure it is really needed to help acceptance.
>> FWIW Cornelia already reviewed both patches.
>
> I'd keep the two patches separate, as each is easier to understand on
> its own IMO.
>
Ok, no problem.
Laurent
next prev parent reply other threads:[~2016-01-08 10:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 11:31 [Qemu-devel] [PATCH 0/6] virtio/vhost cross-endian cleanup Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 1/6] virtio-net: use the backend cross-endian capabilities Greg Kurz
2016-01-07 16:22 ` Laurent Vivier
2016-01-07 17:23 ` Greg Kurz
2016-01-07 18:32 ` Laurent Vivier
2016-01-08 14:19 ` Greg Kurz
2016-01-08 15:25 ` Laurent Vivier
2016-01-08 16:00 ` Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 2/6] Revert "vhost-net: tell tap backend about the vnet endianness" Greg Kurz
2016-01-07 19:52 ` Laurent Vivier
2016-01-08 9:07 ` Greg Kurz
2016-01-08 10:11 ` Cornelia Huck
2016-01-08 10:26 ` Greg Kurz
2016-01-08 11:09 ` Cornelia Huck
2016-01-07 11:32 ` [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper Greg Kurz
2016-01-07 19:55 ` Laurent Vivier
2016-01-08 9:16 ` Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 4/6] virtio: move cross-endian helper to vhost Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper Greg Kurz
2016-01-07 20:07 ` Laurent Vivier
2016-01-08 9:21 ` Greg Kurz
2016-01-08 10:07 ` Cornelia Huck
2016-01-08 10:22 ` Laurent Vivier [this message]
2016-01-07 11:32 ` [Qemu-devel] [PATCH 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets Greg Kurz
2016-01-07 20:25 ` Laurent Vivier
2016-01-08 9:27 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F8DDD.4020209@redhat.com \
--to=lvivier@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.